Bug 133843 – Clean up the WebKit build from unused parameter warning in Webkit2/UIProcess module

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit2

[Rohit]

There is an unused parameter in WebKit2/UIProcess module(clean build for EFL port) in the function definition inside GenericCallback.h file.


[ 85%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp.o
[ 85%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/Geolocation/WebGeolocationManager.cpp.o
In file included from /home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/AutoCorrectionCallback.h:30:0,
                 from /home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/WebPageProxy.h:32,
                 from /home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/WebPageProxy.cpp:28:
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h: In instantiation of ‘void WebKit::invalidateCallbackMap(WTF::HashMap<long unsigned int, T>&, WebKit::CallbackBase::Error) [with T = WTF::RefPtr<WebKit::VoidCallback>]’:
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/WebPageProxy.cpp:4281:42:   required from here
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h:281:6: warning: unused parameter ‘error’ [-Wunused-parameter]
 void invalidateCallbackMap(HashMap<uint64_t, T>& map, CallbackBase::Error error = CallbackBase::Error::Unknown)
      ^
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h: In instantiation of ‘void WebKit::invalidateCallbackMap(WTF::HashMap<long unsigned int, T>&, WebKit::CallbackBase::Error) [with T = WTF::RefPtr<WebKit::GenericCallback<API::Data*> >]’:
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/WebPageProxy.cpp:4282:42:   required from here
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h:281:6: warning: unused parameter ‘error’ [-Wunused-parameter]
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h: In instantiation of ‘void WebKit::invalidateCallbackMap(WTF::HashMap<long unsigned int, T>&, WebKit::CallbackBase::Error) [with T = WTF::RefPtr<WebKit::ImageCallback>]’:
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/WebPageProxy.cpp:4283:43:   required from here
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h:281:6: warning: unused parameter ‘error’ [-Wunused-parameter]
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h: In instantiation of ‘void WebKit::invalidateCallbackMap(WTF::HashMap<long unsigned int, T>&, WebKit::CallbackBase::Error) [with T = WTF::RefPtr<WebKit::GenericCallback<WTF::StringImpl*> >]’:
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/WebPageProxy.cpp:4284:44:   required from here
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h:281:6: warning: unused parameter ‘error’ [-Wunused-parameter]
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h: In instantiation of ‘void WebKit::invalidateCallbackMap(WTF::HashMap<long unsigned int, T>&, WebKit::CallbackBase::Error) [with T = WTF::RefPtr<WebKit::GenericCallback<WebKit::WebSerializedScriptValue*> >]’:
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/WebPageProxy.cpp:4286:56:   required from here
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h:281:6: warning: unused parameter ‘error’ [-Wunused-parameter]
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h: In instantiation of ‘void WebKit::invalidateCallbackMap(WTF::HashMap<long unsigned int, T>&, WebKit::CallbackBase::Error) [with T = WTF::RefPtr<WebKit::ComputedPagesCallback>]’:
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/WebPageProxy.cpp:4287:51:   required from here
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h:281:6: warning: unused parameter ‘error’ [-Wunused-parameter]
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h: In instantiation of ‘void WebKit::invalidateCallbackMap(WTF::HashMap<long unsigned int, T>&, WebKit::CallbackBase::Error) [with T = WTF::RefPtr<WebKit::ValidateCommandCallback>]’:
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/WebPageProxy.cpp:4288:53:   required from here
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h:281:6: warning: unused parameter ‘error’ [-Wunused-parameter]
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h: In instantiation of ‘void WebKit::invalidateCallbackMap(WTF::HashMap<long unsigned int, T>&, WebKit::CallbackBase::Error) [with T = WTF::RefPtr<WebKit::GenericCallback<long unsigned int> >]’:
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/WebPageProxy.cpp:4289:46:   required from here
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h:281:6: warning: unused parameter ‘error’ [-Wunused-parameter]
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h: In instantiation of ‘void WebKit::invalidateCallbackMap(WTF::HashMap<long unsigned int, T>&, WebKit::CallbackBase::Error) [with T = WTF::RefPtr<WebKit::GenericCallback<WebKit::EditingRange> >]’:
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/WebPageProxy.cpp:4290:50:   required from here
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h:281:6: warning: unused parameter ‘error’ [-Wunused-parameter]
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h: In instantiation of ‘void WebKit::invalidateCallbackMap(WTF::HashMap<long unsigned int, T>&, WebKit::CallbackBase::Error) [with T = WTF::RefPtr<WebKit::RectForCharacterRangeCallback>]’:
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/WebPageProxy.cpp:4291:59:   required from here
/home/kumar.rohit/WebKit/Source/WebKit2/UIProcess/GenericCallback.h:281:6: warning: unused parameter ‘error’ [-Wunused-parameter]
[ 85%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/InjectedBundle/InjectedBundle.cpp.o
[ 85%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp.o

[Rohit]

Created attachment 233034 [details]
Patch

[Build Bot]

Comment on attachment 233034 [details]
Patch

Attachment 233034 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6740824721195008

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html

[Build Bot]

Created attachment 233039 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[zalan]

It was fixed by using the parameter.