WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
133837
[Win] Avoid fork bomb during build
https://bugs.webkit.org/show_bug.cgi?id=133837
Summary
[Win] Avoid fork bomb during build
Brent Fulgham
Reported
2014-06-12 18:35:44 PDT
In some build environments, bits of WebKit are built separately. This means that some items (like the Tools/Scripts) directory are not always present. The "build-generated-files.sh" script used on Windows assumes the Tools directory always exists, and expects a valid return value from `num-cpus`. When this script is not present, it passes the result of this failed call to the "make -j" invocation, resulting in a runaway set of forks (a "fork bomb"). This patch corrects this problem by hard-coding a reasonable number of processes to use when the 'num-cpus' call cannot be executed.
Attachments
Patch
(2.55 KB, patch)
2014-06-12 18:42 PDT
,
Brent Fulgham
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2014-06-12 18:35:59 PDT
<
rdar://problem/17296034
>
Brent Fulgham
Comment 2
2014-06-12 18:42:51 PDT
Created
attachment 233021
[details]
Patch
Brent Fulgham
Comment 3
2014-06-12 18:54:14 PDT
Committed
r169927
: <
http://trac.webkit.org/changeset/169927
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug