Bug 133834 – make RegisterAllocator smarter

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Alex Christensen]

The register allocator should not use a hash set for the few registers it keeps track of.  It should use a deque to cycle the register usage, and it should also have a way to indicate a preferred register to allocate.

[Alex Christensen]

Created attachment 233013 [details]
Patch

[Benjamin Poulain]

Comment on attachment 233013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233013&action=review

Very neat! I love it.

> Source/WebCore/cssjit/RegisterAllocator.h:93
> +        RELEASE_ASSERT(m_registers.size());

I think you should put this assertion one line above. Otherwise it looks a little weird accessing the first element before checking if the size is valid.

> Source/WebCore/cssjit/RegisterAllocator.h:113
> +    JSC::MacroAssembler::RegisterID allocateRegisterWithPreference(JSC::MacroAssembler::RegisterID registerID)

registerID -> preferedRegisterID?

> Source/WebCore/cssjit/RegisterAllocator.h:115
> +        UNUSED_PARAM(registerID);

Forgot this?

> Source/WebCore/cssjit/RegisterAllocator.h:133
> +        for (auto reg : m_registers)

reg -> register

[Alex Christensen]

Created attachment 233072 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 233072 [details]
Patch

Clearing flags on attachment: 233072

Committed r169953: <http://trac.webkit.org/changeset/169953>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.