WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
133827
C++ style comment was preventing compile if CPU(ARM_NEON)
https://bugs.webkit.org/show_bug.cgi?id=133827
Summary
C++ style comment was preventing compile if CPU(ARM_NEON)
Marc Juul
Reported
2014-06-12 15:17:35 PDT
Created
attachment 232998
[details]
NEON-specific buildfix for WTF C++ style comment was preventing compile if CPU(ARM_NEON). Changed to C style comment. Unreviewed buildfix. Patch included.
Attachments
NEON-specific buildfix for WTF
(894 bytes, patch)
2014-06-12 15:17 PDT
,
Marc Juul
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1
2014-06-13 00:19:36 PDT
Comment on
attachment 232998
[details]
NEON-specific buildfix for WTF View in context:
https://bugs.webkit.org/attachment.cgi?id=232998&action=review
LGTM, r=me. But please fix the style issue.
> Source/WTF/ChangeLog:8 > + C++ style comment was preventing compile if CPU(ARM_NEON). > + Changed to C style comment. > + > + Unreviewed buildfix. > + > + * wtf/Platform.h:
Please fix the indentation and leave the reviewed by nobody oops line unchanged.
Csaba Osztrogonác
Comment 2
2015-01-14 08:10:55 PST
Landed in
https://trac.webkit.org/changeset/178419
with fixed changelog.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug