Bug 133827 - C++ style comment was preventing compile if CPU(ARM_NEON)
Summary: C++ style comment was preventing compile if CPU(ARM_NEON)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-12 15:17 PDT by Marc Juul
Modified: 2015-01-14 08:11 PST (History)
1 user (show)

See Also:


Attachments
NEON-specific buildfix for WTF (894 bytes, patch)
2014-06-12 15:17 PDT, Marc Juul
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Juul 2014-06-12 15:17:35 PDT
Created attachment 232998 [details]
NEON-specific buildfix for WTF

C++ style comment was preventing compile if CPU(ARM_NEON).
Changed to C style comment.

Unreviewed buildfix.

Patch included.
Comment 1 Csaba Osztrogonác 2014-06-13 00:19:36 PDT
Comment on attachment 232998 [details]
NEON-specific buildfix for WTF

View in context: https://bugs.webkit.org/attachment.cgi?id=232998&action=review

LGTM, r=me. But please fix the style issue.

> Source/WTF/ChangeLog:8
> +	C++ style comment was preventing compile if CPU(ARM_NEON).
> +	Changed to C style comment.
> +
> +        Unreviewed buildfix.
> +	
> +        * wtf/Platform.h:

Please fix the indentation and leave the reviewed by nobody oops line unchanged.
Comment 2 Csaba Osztrogonác 2015-01-14 08:10:55 PST
Landed in https://trac.webkit.org/changeset/178419 with fixed changelog.