Bug 133821 - [ftlopt] A DFG inlined ById access variant should not speak of a chain, but only of what structures to test the base for, whether to use a constant as an alternate base for the actual access, and what structures to check on what additional cell constants
Summary: [ftlopt] A DFG inlined ById access variant should not speak of a chain, but o...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Blocks: 133229
  Show dependency treegraph
Reported: 2014-06-12 14:18 PDT by Filip Pizlo
Modified: 2014-06-13 14:49 PDT (History)
7 users (show)

See Also:

work in progress (47.09 KB, patch)
2014-06-12 14:21 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (57.09 KB, patch)
2014-06-12 16:33 PDT, Filip Pizlo
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-06-12 14:18:21 PDT
This will allow better inlining of cases where there are multiple accesses that share different prototype chains but ultimately hit the same prototype in the end.
Comment 1 Filip Pizlo 2014-06-12 14:21:57 PDT
Created attachment 232986 [details]
work in progress

Compiles and crashes on launch.  It's a good start!
Comment 2 Filip Pizlo 2014-06-12 16:33:42 PDT
Created attachment 233006 [details]
the patch
Comment 3 Mark Hahnenberg 2014-06-13 14:21:33 PDT
Comment on attachment 233006 [details]
the patch

Comment 4 Filip Pizlo 2014-06-13 14:49:51 PDT
Landed in http://trac.webkit.org/changeset/169950