Bug 133814 – JSC build failure when running build-symbol-table-index.py

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Matthew Mirman]

Patch forthcoming.

[Matthew Mirman]

Created attachment 232974 [details]
Fixes build failure on build-symbol-table-index.py

Also adds license to scripts.

[Matthew Mirman]

Created attachment 232976 [details]
Fixes build failure on build-symbol-table-index.py

Also adds license.  Hopefully fixes changelog merge error.

[Mark Rowe (bdash)]

Can you clarify the sequence of events that results in getting in to the state where there are no object files to match? Is that a state that it should be possible to get in to, or is it indicative of an earlier problem too?

[Geoffrey Garen]

Comment on attachment 232976 [details]
Fixes build failure on build-symbol-table-index.py

r=me

[WebKit Commit Bot]

Comment on attachment 232976 [details]
Fixes build failure on build-symbol-table-index.py

Rejecting attachment 232976 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 232976, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
kitpy/common/checkout/changelog.py", line 348, in parse_entries_from_file
    yield ChangeLogEntry(''.join(entry_lines[:-1]), revision=most_probable_revision)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 112, in __init__
    self._parse_entry()
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 207, in _parse_entry
    self._date_line = match.group()
AttributeError: 'NoneType' object has no attribute 'group'

Full output: http://webkit-queues.appspot.com/results/6608226195865600

[Matthew Mirman]

Created attachment 232978 [details]
Same attachment, fixed ChangeLog diff

[Build Bot]

Comment on attachment 232978 [details]
Same attachment, fixed ChangeLog diff

Attachment 232978 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4999710074994688

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html

[Build Bot]

Created attachment 233001 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Matthew Mirman]

(In reply to comment #3)
> Can you clarify the sequence of events that results in getting in to the state where there are no object files to match? Is that a state that it should be possible to get in to, or is it indicative of an earlier problem too?

It might be a problem that .o files aren't being generated, but ultimately if the script fails to produce a set of llvm files all that will happen is that the inliner won't run.    I can't see what exactly is causing this, but one possibility is that the Objects directory exists, but was created earlier and has been emptied and the .o files are being dumped into some other directory.  I'd need a list of environment variables during the failure to see if this was the case.  Another possibility is that the build system is for whatever reason deleting these files before it gets to the script phase, but this seems unlikely.

[Matthew Mirman]

<rdar://problem/17271872>

[Matthew Mirman]

Comment on attachment 232978 [details]
Same attachment, fixed ChangeLog diff

Clearing flags on attachment: 232978

Committed r170076: <http://trac.webkit.org/changeset/170076>

[Matthew Mirman]

All reviewed patches have been landed.  Closing bug.