RESOLVED FIXED 133813
[Win] Avoid crashes in code that converted CFDictionarys to HashMap 
https://bugs.webkit.org/show_bug.cgi?id=133813
Summary [Win] Avoid crashes in code that converted CFDictionarys to HashMap
Brent Fulgham
Reported 2014-06-12 11:33:59 PDT
Work done in the past year to reduce dependencies on outside libraries included some changes to the Windows API routines where CFDictionaries were replaced with HashMaps. This introduced crashes in cases where nullptr were passed to these routines, since the CFDictionary logic would gracefully fail while the HashMap implementation crashes when attempting to hash a nullptr. This patch protects these routines from the nullptr case so that the classes work as intended.
Attachments
Patch (11.57 KB, patch)
2014-06-12 12:18 PDT, Brent Fulgham 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-06-12 12:18:00 PDT
Created attachment 232972 [details] Patch
Brent Fulgham
Comment 2 2014-06-12 12:19:25 PDT
Comment on attachment 232972 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232972&action=review > Source/WebKit/win/WebView.h:89 > + , public WebCore::FullScreenControllerClient This is needed so that std::make_unique can access the FullScreenControlerClient interface for casting.
Brent Fulgham
Comment 3 2014-06-12 13:15:46 PDT
The efl-wk2 error seems spurious. It does not build Windows-specific sources.
Radar WebKit Bug Importer
Comment 4 2014-06-12 13:30:18 PDT
<rdar://problem/17291647>
Brent Fulgham
Comment 5 2014-06-12 13:34:59 PDT
Committed r169909: <http://trac.webkit.org/changeset/169909>
Note You need to log in before you can comment on or make changes to this bug.