Work done in the past year to reduce dependencies on outside libraries included some changes to the Windows API routines where CFDictionaries were replaced with HashMaps. This introduced crashes in cases where nullptr were passed to these routines, since the CFDictionary logic would gracefully fail while the HashMap implementation crashes when attempting to hash a nullptr.
This patch protects these routines from the nullptr case so that the classes work as intended.
Created attachment 232972 [details]
Comment on attachment 232972 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=232972&action=review
> + , public WebCore::FullScreenControllerClient
This is needed so that std::make_unique can access the FullScreenControlerClient interface for casting.
The efl-wk2 error seems spurious. It does not build Windows-specific sources.
Committed r169909: <http://trac.webkit.org/changeset/169909>