Bug 133813 - [Win] Avoid crashes in code that converted CFDictionarys to HashMap
Summary: [Win] Avoid crashes in code that converted CFDictionarys to HashMap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Unspecified
: P2 Critical
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-12 11:33 PDT by Brent Fulgham
Modified: 2014-06-12 13:34 PDT (History)
3 users (show)

See Also:

Attachments
Patch (11.57 KB, patch)
2014-06-12 12:18 PDT, Brent Fulgham 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-06-12 11:33:59 PDT 
Work done in the past year to reduce dependencies on outside libraries included some changes to the Windows API routines where CFDictionaries were replaced with HashMaps. This introduced crashes in cases where nullptr were passed to these routines, since the CFDictionary logic would gracefully fail while the HashMap implementation crashes when attempting to hash a nullptr.

This patch protects these routines from the nullptr case so that the classes work as intended.
Comment 1 Brent Fulgham 2014-06-12 12:18:00 PDT 
Created attachment 232972 [details]
Patch
Comment 2 Brent Fulgham 2014-06-12 12:19:25 PDT 
Comment on attachment 232972 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232972&action=review

> Source/WebKit/win/WebView.h:89
> +    , public WebCore::FullScreenControllerClient

This is needed so that std::make_unique can access the FullScreenControlerClient interface for casting.
Comment 3 Brent Fulgham 2014-06-12 13:15:46 PDT 
The efl-wk2 error seems spurious. It does not build Windows-specific sources.
Comment 4 Radar WebKit Bug Importer 2014-06-12 13:30:18 PDT 
<rdar://problem/17291647>
Comment 5 Brent Fulgham 2014-06-12 13:34:59 PDT 
Committed r169909: <http://trac.webkit.org/changeset/169909>