Bug 13381 - [js-collector-tweaks] Make Window object not an oversize object any more
Summary: [js-collector-tweaks] Make Window object not an oversize object any more
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks: 13382 13389
  Show dependency treegraph
 
Reported: 2007-04-18 00:02 PDT by Maciej Stachowiak
Modified: 2007-04-23 02:13 PDT (History)
0 users

See Also:


Attachments
01-js-gc-window-not-oversize.patch.txt (23.86 KB, patch)
2007-04-18 00:04 PDT, Maciej Stachowiak
darin: review-
Details | Formatted Diff | Diff
omitting optimization level changes (23.04 KB, patch)
2007-04-18 14:56 PDT, Maciej Stachowiak
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2007-04-18 00:02:23 PDT
Window is the only object to make use of the JavaCriptCore oversize allocator; avoiding use of this should speed up garbage collection when there are many tabs/windows/frames open, and also enables a bunch of further optimizations to the collector.
Comment 1 Maciej Stachowiak 2007-04-18 00:04:51 PDT
Created attachment 14062 [details]
01-js-gc-window-not-oversize.patch.txt
Comment 2 Darin Adler 2007-04-18 10:58:25 PDT
Comment on attachment 14062 [details]
01-js-gc-window-not-oversize.patch.txt

Optimization level changes should be done in Configurations/Base.xcconfig instead of in the project.pbxproj.

Change otherwise looks fine to me. Although I'm not crazy about the name "d".
Comment 3 Maciej Stachowiak 2007-04-18 14:56:29 PDT
Created attachment 14081 [details]
omitting optimization level changes

The optimization level changes were accidental.
Comment 4 Geoffrey Garen 2007-04-18 21:13:35 PDT
Comment on attachment 14081 [details]
omitting optimization level changes

r=me