Bug 133795 - Have ScriptExecutionContext::Task lambdas take in a ScriptExecutionContext reference
Summary: Have ScriptExecutionContext::Task lambdas take in a ScriptExecutionContext re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-12 05:49 PDT by Zan Dobersek
Modified: 2014-06-16 09:46 PDT (History)
1 user (show)

See Also:

Attachments
Patch (76.12 KB, patch)
2014-06-12 06:05 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-06-12 05:49:56 PDT 
Have ScriptExecutionContext::Task lambdas take in a ScriptExecutionContext reference
Comment 1 Zan Dobersek 2014-06-12 06:05:06 PDT 
Created attachment 232950 [details]
Patch
Comment 2 WebKit Commit Bot 2014-06-12 06:06:29 PDT 
Attachment 232950 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/ScriptExecutionContext.h:120:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:127:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:144:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/bindings/js/JSDOMGlobalObjectTask.cpp:86:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/workers/WorkerThread.cpp:216:  Extra space before )  [whitespace/parens] [2]
ERROR: Source/WebCore/loader/WorkerThreadableLoader.cpp:161:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/loader/WorkerThreadableLoader.cpp:172:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/loader/WorkerThreadableLoader.cpp:184:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/loader/WorkerThreadableLoader.cpp:197:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/loader/WorkerThreadableLoader.cpp:208:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/loader/WorkerThreadableLoader.cpp:230:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 11 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zan Dobersek 2014-06-16 09:46:28 PDT 
Comment on attachment 232950 [details]
Patch

Clearing flags on attachment: 232950

Committed r170013: <http://trac.webkit.org/changeset/170013>
Comment 4 Zan Dobersek 2014-06-16 09:46:34 PDT 
All reviewed patches have been landed.  Closing bug.