Bug 133779 – [iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

[iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing

[Simon Fraser (smfr)]

Created attachment 232925 [details]
Patch

[Benjamin Poulain]

Comment on attachment 232925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232925&action=review

> Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:247
> +    WebPageProxy *webPageProxy = [_contentView page];

* on the wrong side.

> Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:248
> +    webPageProxy->setViewportConfigurationMinimumLayoutSize(WebCore::FloatSize(bounds.size));

You should also send setMaximumUnobscuredSize() so that we can use viewport units.
You could set setViewportConfigurationMinimumLayoutSizeForMinimalUI() but there is no test for it.

They should all take the same size in this case.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2200
> +    if (m_useTestingViewportConfiguration) {
> +        m_viewportConfiguration.setDefaultConfiguration(ViewportConfiguration::testingParameters());
> +        return;
> +    }

Shouldn't this be above the case with !frame?

[Simon Fraser (smfr)]

https://trac.webkit.org/r169869