Bug 133775 - Keep CFDataRefs in SharedBuffer instead of merging them
Summary: Keep CFDataRefs in SharedBuffer instead of merging them
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-11 16:06 PDT by Pratik Solanki
Modified: 2014-06-11 17:47 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.25 KB, patch)
2014-06-11 16:15 PDT, Pratik Solanki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2014-06-11 16:06:34 PDT 
Keep CFDataRefs in SharedBuffer instead of merging them
Comment 1 Pratik Solanki 2014-06-11 16:15:53 PDT 
Created attachment 232919 [details]
Patch
Comment 2 Alexey Proskuryakov 2014-06-11 16:30:24 PDT 
Comment on attachment 232919 [details]
Patch

There is a case for (count == 1) above the modified code, should it be updated in the same way too?

r=me assuming that there is a measurable improvement somewhere.
Comment 3 Alexey Proskuryakov 2014-06-11 16:31:07 PDT 
> There is a case for (count == 1) above the modified code, should it be updated in the same way too?

No, I misread that code.
Comment 4 Pratik Solanki 2014-06-11 17:41:36 PDT 
(In reply to comment #2)
> (From update of attachment 232919 [details])

> r=me assuming that there is a measurable improvement somewhere.

Thanks for the review. By itself this will not improve performance but next up I would like to pass the SharedBuffer all the way down to IPC message send so that we can avoid merging the CFData and directly write to the IPC message.
Comment 5 WebKit Commit Bot 2014-06-11 17:47:20 PDT 
Comment on attachment 232919 [details]
Patch

Clearing flags on attachment: 232919

Committed r169868: <http://trac.webkit.org/changeset/169868>
Comment 6 WebKit Commit Bot 2014-06-11 17:47:23 PDT 
All reviewed patches have been landed.  Closing bug.