Bug 133770 - WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
Summary: WTR cleanup: push per-test viewport configuration into TestController, where ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-11 14:56 PDT by Simon Fraser (smfr)
Modified: 2014-06-11 15:09 PDT (History)
1 user (show)

See Also:

Attachments
Patch (13.49 KB, patch)
2014-06-11 14:57 PDT, Simon Fraser (smfr) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-06-11 14:56:52 PDT 
WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
Comment 1 Simon Fraser (smfr) 2014-06-11 14:57:56 PDT 
Created attachment 232910 [details]
Patch
Comment 2 Anders Carlsson 2014-06-11 14:59:39 PDT 
Comment on attachment 232910 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232910&action=review

> Tools/WebKitTestRunner/ios/TestControllerIOS.mm:72
> +    if (shouldMakeViewportFlexible(test.pathOrURL())) {

Early return?

> Tools/WebKitTestRunner/mac/TestControllerMac.mm:89
> +    WKRetainPtr<WKMutableDictionaryRef> viewOptions = adoptWK(WKMutableDictionaryCreate());
> +    WKRetainPtr<WKStringRef> useThreadedScrollingKey = adoptWK(WKStringCreateWithUTF8CString("ThreadedScrolling"));
> +    WKRetainPtr<WKBooleanRef> useThreadedScrollingValue = adoptWK(WKBooleanCreate(shouldUseThreadedScrolling(test.pathOrURL())));
> +    WKDictionarySetItem(viewOptions.get(), useThreadedScrollingKey.get(), useThreadedScrollingValue.get());
> +
> +    WKRetainPtr<WKStringRef> useRemoteLayerTreeKey = adoptWK(WKStringCreateWithUTF8CString("RemoteLayerTree"));
> +    WKRetainPtr<WKBooleanRef> useRemoteLayerTreeValue = adoptWK(WKBooleanCreate(shouldUseRemoteLayerTree()));

These can all be auto.
Comment 3 Simon Fraser (smfr) 2014-06-11 15:09:51 PDT 
http://trac.webkit.org/changeset/169845