RESOLVED FIXED 133770
WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it 
https://bugs.webkit.org/show_bug.cgi?id=133770
Summary WTR cleanup: push per-test viewport configuration into TestController, where ...
Simon Fraser (smfr)
Reported 2014-06-11 14:56:52 PDT
WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
Attachments
Patch (13.49 KB, patch)
2014-06-11 14:57 PDT, Simon Fraser (smfr) 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-06-11 14:57:56 PDT
Created attachment 232910 [details] Patch
Anders Carlsson
Comment 2 2014-06-11 14:59:39 PDT
Comment on attachment 232910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232910&action=review > Tools/WebKitTestRunner/ios/TestControllerIOS.mm:72 > + if (shouldMakeViewportFlexible(test.pathOrURL())) { Early return? > Tools/WebKitTestRunner/mac/TestControllerMac.mm:89 > + WKRetainPtr<WKMutableDictionaryRef> viewOptions = adoptWK(WKMutableDictionaryCreate()); > + WKRetainPtr<WKStringRef> useThreadedScrollingKey = adoptWK(WKStringCreateWithUTF8CString("ThreadedScrolling")); > + WKRetainPtr<WKBooleanRef> useThreadedScrollingValue = adoptWK(WKBooleanCreate(shouldUseThreadedScrolling(test.pathOrURL()))); > + WKDictionarySetItem(viewOptions.get(), useThreadedScrollingKey.get(), useThreadedScrollingValue.get()); > + > + WKRetainPtr<WKStringRef> useRemoteLayerTreeKey = adoptWK(WKStringCreateWithUTF8CString("RemoteLayerTree")); > + WKRetainPtr<WKBooleanRef> useRemoteLayerTreeValue = adoptWK(WKBooleanCreate(shouldUseRemoteLayerTree())); These can all be auto.
Simon Fraser (smfr)
Comment 3 2014-06-11 15:09:51 PDT
http://trac.webkit.org/changeset/169845
Note You need to log in before you can comment on or make changes to this bug.