Bug 133766 - Implement swipeWithEvent for non-fluid swipes
Summary: Implement swipeWithEvent for non-fluid swipes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-11 14:17 PDT by Tim Horton
Modified: 2014-06-11 15:47 PDT (History)
2 users (show)

See Also:

Attachments
patch (1.40 KB, patch)
2014-06-11 14:21 PDT, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-06-11 14:17:46 PDT 
<rdar://problem/17126889>
Comment 1 Tim Horton 2014-06-11 14:21:37 PDT 
Created attachment 232904 [details]
patch
Comment 2 Anders Carlsson 2014-06-11 14:24:32 PDT 
Comment on attachment 232904 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232904&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:1188
> +    if ([self shouldIgnoreMouseEvents])
> +        return;
> +
> +    if (!_data->_allowsBackForwardNavigationGestures)
> +        return;
> +
> +    if ([event deltaX] > 0.0)
> +        _data->_page->goBack();
> +    else if ([event deltaX] < 0.0)
> +        _data->_page->goForward();

Dot syntax.

Should we call super if we can't swipe?
Comment 3 Tim Horton 2014-06-11 15:47:59 PDT 
http://trac.webkit.org/changeset/169850