WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
133766
Implement swipeWithEvent for non-fluid swipes
https://bugs.webkit.org/show_bug.cgi?id=133766
Summary
Implement swipeWithEvent for non-fluid swipes
Tim Horton
Reported
2014-06-11 14:17:46 PDT
<
rdar://problem/17126889
>
Attachments
patch
(1.40 KB, patch)
2014-06-11 14:21 PDT
,
Tim Horton
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2014-06-11 14:21:37 PDT
Created
attachment 232904
[details]
patch
Anders Carlsson
Comment 2
2014-06-11 14:24:32 PDT
Comment on
attachment 232904
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=232904&action=review
> Source/WebKit2/UIProcess/API/mac/WKView.mm:1188 > + if ([self shouldIgnoreMouseEvents]) > + return; > + > + if (!_data->_allowsBackForwardNavigationGestures) > + return; > + > + if ([event deltaX] > 0.0) > + _data->_page->goBack(); > + else if ([event deltaX] < 0.0) > + _data->_page->goForward();
Dot syntax. Should we call super if we can't swipe?
Tim Horton
Comment 3
2014-06-11 15:47:59 PDT
http://trac.webkit.org/changeset/169850
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug