Add LLVM FastISel abort option for coverage testing

[Juergen Ributzka]

Add LLVM FastISel abort option for coverage testing

[Juergen Ributzka]

Created attachment 232894 [details]
Patch

[Filip Pizlo]

Comment on attachment 232894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232894&action=review

> Source/JavaScriptCore/llvm/InitializeLLVMPOSIX.cpp:38
> +typedef LLVMAPI* (*InitializerFunction)(void (*)(const char*, ...), bool FastISelAbort);

Call it fastISelAbort

> Source/JavaScriptCore/llvm/library/LLVMExports.cpp:63
> +extern "C" JSC::LLVMAPI* initializeAndGetJSCLLVMAPI(void (*callback)(const char*, ...), bool FastISelAbort)

Our naming convention would have this variable start with lower case: fastISelAbort.

[Juergen Ributzka]

Created attachment 233007 [details]
Patch

[Geoffrey Garen]

Comment on attachment 233007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233007&action=review

> Source/JavaScriptCore/llvm/library/LLVMExports.cpp:99
> +    unsigned numArgs = sizeof(args) / sizeof(const char *) - (fastISelAbort ? 0 : 2);

"char *" => "char*" in WebKit style.

[Juergen Ributzka]

Created attachment 233312 [details]
Patch

[Juergen Ributzka]

Thanks Filip and Geoff. I am still not fully accustomed to the webkit coding style.

[Juergen Ributzka]

Abandon patch - it is obsolete.