Bug 133732 - Wrap NSURLRequest in bundle API
Summary: Wrap NSURLRequest in bundle API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-11 04:48 PDT by Antti Koivisto
Modified: 2014-06-11 10:13 PDT (History)
3 users (show)

See Also:

Attachments
patch (12.90 KB, patch)
2014-06-11 04:55 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-06-11 04:48:01 PDT 
We don't want to construct actual NSURLRequests in web process side unless really needed.
Comment 1 Antti Koivisto 2014-06-11 04:52:52 PDT 
<rdar://problem/17267217>
Comment 2 Antti Koivisto 2014-06-11 04:55:50 PDT 
Created attachment 232861 [details]
patch
Comment 3 WebKit Commit Bot 2014-06-11 04:57:09 PDT 
Attachment 232861 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:230:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Andreas Kling 2014-06-11 08:27:20 PDT 
Comment on attachment 232861 [details]
patch

This patch makes me happy!
Comment 5 Alexey Proskuryakov 2014-06-11 10:13:38 PDT 
Antti landed this in <http://trac.webkit.org/changeset/169807>.