Bug 133718 - DFG::ByteCodeParser should emit native call/construct only in FTL mode, since the DFG backend can't do anything about them and the presence of function checks just means less efficient code
Summary: DFG::ByteCodeParser should emit native call/construct only in FTL mode, since...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Matthew Mirman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-10 21:19 PDT by Filip Pizlo
Modified: 2014-06-11 12:57 PDT (History)
8 users (show)

See Also:

Attachments
Added check for ftl mode before emitting native calls (1.58 KB, patch)
2014-06-11 11:48 PDT, Matthew Mirman 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-06-10 21:19:20 PDT 
...
Comment 1 Matthew Mirman 2014-06-11 11:48:06 PDT 
Created attachment 232878 [details]
Added check for ftl mode before emitting native calls

For branch ftlopt.  Passed all tests, both 32 and 64 bit.
Comment 2 Filip Pizlo 2014-06-11 11:55:27 PDT 
Comment on attachment 232878 [details]
Added check for ftl mode before emitting native calls

Cool!  I will land.
Comment 3 Filip Pizlo 2014-06-11 12:57:16 PDT 
Landed in http://trac.webkit.org/changeset/169819