Bug 133702 - [iOS][WK2] ScrollingTreeOverflowScrollingNode does not use asynchronous touch dispatch
Summary: [iOS][WK2] ScrollingTreeOverflowScrollingNode does not use asynchronous touch...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-10 15:40 PDT by Benjamin Poulain
Modified: 2014-06-10 20:53 PDT (History)
7 users (show)

See Also:


Attachments
Patch (12.65 KB, patch)
2014-06-10 15:43 PDT, Benjamin Poulain
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-06-10 15:40:56 PDT
[iOS][WK2] ScrollingTreeOverflowScrollingNode does not use asynchronous touch dispatch
Comment 1 Benjamin Poulain 2014-06-10 15:43:58 PDT
Created attachment 232822 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-06-10 16:50:19 PDT
Comment on attachment 232822 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232822&action=review

> Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:48
> +

Extra line.

> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:533
> +    [m_contentView willStartPanOrPinchGesture];

The name of the content view method doesn't communicate that it might be some inner UIScrollView that will begin a pan or pinch, so perhaps it needs a better name.
Comment 3 Benjamin Poulain 2014-06-10 20:53:44 PDT
Committed r169791: <http://trac.webkit.org/changeset/169791>