Bug 133697 - [Cocoa] Handling authentication challenges should not require multiple delegate methods
Summary: [Cocoa] Handling authentication challenges should not require multiple delega...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-10 13:51 PDT by mitz
Modified: 2014-06-10 17:02 PDT (History)
0 users

See Also:

Attachments
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:] (27.40 KB, patch)
2014-06-10 14:43 PDT, mitz 		no flags Details | Formatted Diff | Diff
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:] (34.54 KB, patch)
2014-06-10 16:04 PDT, mitz 		no flags Details | Formatted Diff | Diff
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:] (35.15 KB, patch)
2014-06-10 16:20 PDT, mitz 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-06-10 13:51:44 PDT 
NSURLAuthenticationChallengeSender now makes it possible to respond to authentication challenges with a single delegate method. We can add that kind of delegate method to WKNavigationDelegate.
Comment 1 mitz 2014-06-10 14:43:18 PDT 
Created attachment 232821 [details]
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:]
Comment 2 mitz 2014-06-10 16:04:08 PDT 
Created attachment 232826 [details]
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:]
Comment 3 mitz 2014-06-10 16:08:19 PDT 
Comment on attachment 232826 [details]
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:]

This just contains build fixes on top of the previous patch, which Anders has reviewed.
Comment 4 mitz 2014-06-10 16:20:19 PDT 
Created attachment 232827 [details]
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:]
Comment 5 mitz 2014-06-10 17:02:02 PDT 
Fixed in <http://trac.webkit.org/r169782>.