Bug 133688 - Modernize loop code in scrolling tree code
Summary: Modernize loop code in scrolling tree code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-10 12:00 PDT by Simon Fraser (smfr)
Modified: 2014-06-10 15:15 PDT (History)
9 users (show)

See Also:


Attachments
Patch (4.89 KB, patch)
2014-06-10 12:01 PDT, Simon Fraser (smfr)
andersca: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (528.87 KB, application/zip)
2014-06-10 13:09 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-06-10 12:00:39 PDT
Modernize loop code in scrolling tree code
Comment 1 Simon Fraser (smfr) 2014-06-10 12:01:03 PDT
Created attachment 232801 [details]
Patch
Comment 2 Anders Carlsson 2014-06-10 12:27:51 PDT
Comment on attachment 232801 [details]
Patch

Instead of *m_children.get(), just use *m_children.
Comment 3 Build Bot 2014-06-10 13:09:37 PDT
Comment on attachment 232801 [details]
Patch

Attachment 232801 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5299580933505024

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 4 Build Bot 2014-06-10 13:09:41 PDT
Created attachment 232808 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Simon Fraser (smfr) 2014-06-10 15:15:42 PDT
https://trac.webkit.org/r169773