Bug 133681 – REGRESSION (r167937): Do not use effective zoom factor while resolving media query's min-, max-(device)width/height values.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

Using effective zoom factor give false result for width/height values.

[zalan]

<rdar://problem/17233577>

[zalan]

Created attachment 232792 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 232792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232792&action=review

> Source/WebCore/css/CSSToLengthConversionData.cpp:52
> +        return 0.0;

0

> Source/WebCore/css/CSSToLengthConversionData.cpp:63
>          return 0.0;

0

> Source/WebCore/css/MediaQueryEvaluator.cpp:730
> +            m_frame->document()->renderView(), 1, false);

So mysterious.

Why doesn't the second constructor just initialize m_zoom to 1? It seems to leave it uninitialized.

[Simon Fraser (smfr)]

Comment on attachment 232792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232792&action=review

> LayoutTests/fast/media/media-query-with-scaled-content.html:27
> +    setTimeout(function() { window.internals.setPageZoomFactor(1); testRunner.notifyDone(); }, 100);

No timeout!

[Bem Jones-Bey]

Comment on attachment 232792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232792&action=review

>> Source/WebCore/css/MediaQueryEvaluator.cpp:730
>> +            m_frame->document()->renderView(), 1, false);
> 
> So mysterious.
> 
> Why doesn't the second constructor just initialize m_zoom to 1? It seems to leave it uninitialized.

If an explicit zoom isn't provided, m_useEffectiveZoom is set to true, and it uses the zoom on the style instead of m_zoom.

[zalan]

Created attachment 232800 [details]
Patch

[zalan]

Comment on attachment 232800 [details]
Patch

EWS

[Build Bot]

Comment on attachment 232800 [details]
Patch

Attachment 232800 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5543294557749248

New failing tests:
fast/media/media-query-with-scaled-content.html

[Build Bot]

Created attachment 232803 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[zalan]

Created attachment 232806 [details]
Patch

[zalan]

Comment on attachment 232806 [details]
Patch

fixed win build. ews testing.

[Build Bot]

Comment on attachment 232806 [details]
Patch

Attachment 232806 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6288843502256128

New failing tests:
fast/media/media-query-with-scaled-content.html

[Build Bot]

Created attachment 232819 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[zalan]

Created attachment 232820 [details]
Patch

[zalan]

Comment on attachment 232820 [details]
Patch

Try EWS again now with the fix included. :)

[WebKit Commit Bot]

Comment on attachment 232820 [details]
Patch

Clearing flags on attachment: 232820

Committed r169779: <http://trac.webkit.org/changeset/169779>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.