RESOLVED FIXED 133677
Page::findStringMatchingRanges() should take Vector<RefPtr<Range>> by reference instead of pointer 
https://bugs.webkit.org/show_bug.cgi?id=133677
Summary Page::findStringMatchingRanges() should take Vector<RefPtr<Range>> by referen...
Zan Dobersek
Reported 2014-06-09 23:13:15 PDT
Page::findStringMatchingRanges() should take Vector<RefPtr<Range>> by reference instead of pointer
Attachments
Patch (6.75 KB, patch)
2014-06-09 23:15 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (7.69 KB, patch)
2014-06-14 11:01 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-06-09 23:15:18 PDT
Created attachment 232772 [details] Patch
Anders Carlsson
Comment 2 2014-06-11 20:21:26 PDT
Comment on attachment 232772 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232772&action=review > Source/WebCore/page/Page.cpp:542 > +void Page::findStringMatchingRanges(const String& target, FindOptions options, int limit, Vector<RefPtr<Range>>& matchRanges, int& indexForSelection) Can this be a const reference?
Zan Dobersek
Comment 3 2014-06-14 10:56:19 PDT
Comment on attachment 232772 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232772&action=review >> Source/WebCore/page/Page.cpp:542 >> +void Page::findStringMatchingRanges(const String& target, FindOptions options, int limit, Vector<RefPtr<Range>>& matchRanges, int& indexForSelection) > > Can this be a const reference? No, that would clash with Editor::countMatchesForText() which expects a pointer to a non-const Vector.
Zan Dobersek
Comment 4 2014-06-14 11:01:04 PDT
Created attachment 233112 [details] Patch
Zan Dobersek
Comment 5 2014-06-16 09:42:59 PDT
Comment on attachment 233112 [details] Patch Clearing flags on attachment: 233112 Committed r170012: <http://trac.webkit.org/changeset/170012>
Zan Dobersek
Comment 6 2014-06-16 09:43:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.