Bug 133673 - Turning on DUMP_PROPERTYMAP_STATS causes a build failure
Summary: Turning on DUMP_PROPERTYMAP_STATS causes a build failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-09 22:06 PDT by Ryosuke Niwa
Modified: 2014-06-11 13:22 PDT (History)
6 users (show)

See Also:


Attachments
Fixes the build failure (8.97 KB, patch)
2014-06-09 22:26 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Fixes the bug (10.89 KB, patch)
2014-06-10 18:01 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-06-09 22:06:25 PDT
Add a bunch of stuff to make it buildable again.
Comment 1 Ryosuke Niwa 2014-06-09 22:26:26 PDT
Created attachment 232768 [details]
Fixes the build failure
Comment 2 WebKit Commit Bot 2014-06-09 22:27:28 PDT
Attachment 232768 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/Structure.cpp:815:  Extra space before )  [whitespace/parens] [2]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2014-06-10 13:18:00 PDT
Comment on attachment 232768 [details]
Fixes the build failure

This code counts collisions and rehashes the same. :|
Comment 4 Ryosuke Niwa 2014-06-10 18:01:36 PDT
Created attachment 232838 [details]
Fixes the bug
Comment 5 WebKit Commit Bot 2014-06-10 18:03:30 PDT
Attachment 232838 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/Structure.cpp:818:  Extra space before )  [whitespace/parens] [2]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Ryosuke Niwa 2014-06-11 13:22:01 PDT
Comment on attachment 232838 [details]
Fixes the bug

Clearing flags on attachment: 232838

Committed r169824: <http://trac.webkit.org/changeset/169824>
Comment 7 Ryosuke Niwa 2014-06-11 13:22:06 PDT
All reviewed patches have been landed.  Closing bug.