Bug 133659 – iOS WebKit: Crash in charactersAroundPosition

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Enrica Casucci]

This is a crash introduced with http://trac.webkit.org/changeset/169500.

When we compute the editor state information we don't need to compute the charactersAroundPosition if we are not in editable content.

<rdar://problem/17220870>

[Enrica Casucci]

Created attachment 232737 [details]
Patch

[WebKit Commit Bot]

Attachment 232737 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:718:  Missing space before ( in if(  [whitespace/parens] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Enrica Casucci]

I've already fixed the style issue.

[Benjamin Poulain]

Comment on attachment 232737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232737&action=review

> Source/WebCore/editing/VisibleUnits.cpp:1843
> +            if (index >= maxCharacters)
> +                break;

Shouldn't this be after "characters[index++] = characterString[i];".

You may want to change the for() loop into a while loop. Having a for() loop that breaks into the flow  tends to add complexity.

[Enrica Casucci]

Committed revision 169728.