Bug 133658 - Flash video controls hit-test incorrectly after changing topContentInset
Summary: Flash video controls hit-test incorrectly after changing topContentInset
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-09 14:56 PDT by Beth Dakin
Modified: 2014-06-09 15:31 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.83 KB, patch)
2014-06-09 15:01 PDT, Beth Dakin
andersca: review-
Details | Formatted Diff | Diff
Patch (2.79 KB, patch)
2014-06-09 15:05 PDT, Beth Dakin
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-06-09 14:56:12 PDT
Flash video controls hit-test incorrectly after changing topContentInset

<rdar://problem/16978590>
Comment 1 Beth Dakin 2014-06-09 15:01:09 PDT
Created attachment 232735 [details]
Patch
Comment 2 Anders Carlsson 2014-06-09 15:02:25 PDT
Comment on attachment 232735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232735&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2109
> +    if (insetDidChange) {

Can use an early return here instead.
Comment 3 Beth Dakin 2014-06-09 15:05:25 PDT
Created attachment 232736 [details]
Patch
Comment 4 Beth Dakin 2014-06-09 15:31:44 PDT
Thanks Anders! http://trac.webkit.org/changeset/169724