RESOLVED FIXED 133653
HTML*ListElement wrappers have custom getOwnPropertySlot()s for no good reason. 
https://bugs.webkit.org/show_bug.cgi?id=133653
Summary HTML*ListElement wrappers have custom getOwnPropertySlot()s for no good reason.
Andreas Kling
Reported 2014-06-09 13:09:43 PDT
Patchy patch coming.
Attachments
Patch (1.49 KB, patch)
2014-06-09 13:10 PDT, Andreas Kling 		mhahnenberg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-06-09 13:10:10 PDT
Created attachment 232726 [details] Patch
Mark Hahnenberg
Comment 2 2014-06-09 13:11:30 PDT
Comment on attachment 232726 [details] Patch r=me
Mark Hahnenberg
Comment 3 2014-06-09 13:11:53 PDT
You might have to rebaseline bindings tests too.
Andreas Kling
Comment 4 2014-06-09 13:18:40 PDT
Committed r169709: <http://trac.webkit.org/changeset/169709>
Joseph Pecoraro
Comment 5 2014-06-09 14:09:57 PDT
Comment on attachment 232726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232726&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:645 > + return 1 if $interfaceName =~ "List" && !($interfaceName =~ "Element"); Nit: "!~" operator. <http://perldoc.perl.org/perlop.html#Binding-Operators> Binary "!~" is just like "=~" except the return value is negated in the logical sense.
Note You need to log in before you can comment on or make changes to this bug.