Bug 133653 - HTML*ListElement wrappers have custom getOwnPropertySlot()s for no good reason.
Summary: HTML*ListElement wrappers have custom getOwnPropertySlot()s for no good reason.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-09 13:09 PDT by Andreas Kling
Modified: 2014-06-09 14:09 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.49 KB, patch)
2014-06-09 13:10 PDT, Andreas Kling 		mhahnenberg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-06-09 13:09:43 PDT 
Patchy patch coming.
Comment 1 Andreas Kling 2014-06-09 13:10:10 PDT 
Created attachment 232726 [details]
Patch
Comment 2 Mark Hahnenberg 2014-06-09 13:11:30 PDT 
Comment on attachment 232726 [details]
Patch

r=me
Comment 3 Mark Hahnenberg 2014-06-09 13:11:53 PDT 
You might have to rebaseline bindings tests too.
Comment 4 Andreas Kling 2014-06-09 13:18:40 PDT 
Committed r169709: <http://trac.webkit.org/changeset/169709>
Comment 5 Joseph Pecoraro 2014-06-09 14:09:57 PDT 
Comment on attachment 232726 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232726&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:645
> +    return 1 if $interfaceName =~ "List" && !($interfaceName =~ "Element");

Nit: "!~" operator.

<http://perldoc.perl.org/perlop.html#Binding-Operators>
Binary "!~" is just like "=~" except the return value is negated in the logical sense.