Bug 133619 - [Mac] checkboxes and radio buttons animate incorrectly
Summary: [Mac] checkboxes and radio buttons animate incorrectly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-08 14:20 PDT by Dean Jackson
Modified: 2014-06-08 17:03 PDT (History)
0 users

See Also:

Attachments
Patch (5.03 KB, patch)
2014-06-08 14:25 PDT, Dean Jackson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-06-08 14:20:18 PDT 
[Mac] checkboxes and radio buttons animate incorrectly
Comment 1 Dean Jackson 2014-06-08 14:25:20 PDT 
Created attachment 232685 [details]
Patch
Comment 2 Sam Weinig 2014-06-08 14:30:48 PDT 
Comment on attachment 232685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232685&action=review

> Source/WebCore/platform/mac/ThemeMac.mm:304
> +static const std::array<FloatSize, 3>& checkboxOffsets()

I think this could use a comment explaining what they the offsets are used for.

> Source/WebCore/platform/mac/ThemeMac.mm:332
> +static const std::array<FloatSize, 3>& radioOffsets()

I think this could use a comment explaining what they the offsets are used for.
Comment 3 Dean Jackson 2014-06-08 17:03:14 PDT 
Committed r169685: <http://trac.webkit.org/changeset/169685>