Bug 133618 - Reduce the overhead of updating the animatable style on ARMv7
Summary: Reduce the overhead of updating the animatable style on ARMv7
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-08 14:19 PDT by Benjamin Poulain
Modified: 2014-06-10 20:36 PDT (History)
7 users (show)

See Also:

Attachments
Patch (6.02 KB, patch)
2014-06-08 14:38 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (6.33 KB, patch)
2014-06-09 16:14 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (6.34 KB, patch)
2014-06-10 13:53 PDT, Benjamin Poulain 		simon.fraser: review+
simon.fraser: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-06-08 14:19:48 PDT 
Reduce the overhead of updating the animatable style on ARMv7
Comment 1 Benjamin Poulain 2014-06-08 14:38:09 PDT 
Created attachment 232686 [details]
Patch
Comment 2 Benjamin Poulain 2014-06-09 16:14:33 PDT 
Created attachment 232745 [details]
Patch
Comment 3 Benjamin Poulain 2014-06-10 13:53:09 PDT 
Created attachment 232812 [details]
Patch
Comment 4 Simon Fraser (smfr) 2014-06-10 18:19:31 PDT 
Comment on attachment 232812 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232812&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1066
> +    CGFloat scaleFactor = contentZoomScale(self);
> +    [_contentView scaleFactorDidChange:scaleFactor];

Unrelated?
Comment 5 Tim Horton 2014-06-10 18:26:36 PDT 
Comment on attachment 232812 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232812&action=review

> Source/WebCore/ChangeLog:8
> +        While udpating the style for animations, most of the time spent was pure calling overhead.

updating
Comment 6 Benjamin Poulain 2014-06-10 20:36:26 PDT 
Committed r169790: <http://trac.webkit.org/changeset/169790>