Bug 133615 - ScriptExecutionContext::Task parameters should always be rvalue references
Summary: ScriptExecutionContext::Task parameters should always be rvalue references
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-07 22:49 PDT by Zan Dobersek
Modified: 2014-06-18 11:05 PDT (History)
5 users (show)

See Also:

Attachments
Patch (14.21 KB, patch)
2014-06-07 22:58 PDT, Zan Dobersek 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-06-07 22:49:22 PDT 
ScriptExecutionContext::Task parameters should always be rvalue references
Comment 1 Zan Dobersek 2014-06-07 22:58:47 PDT 
Created attachment 232679 [details]
Patch
Comment 2 Darin Adler 2014-06-17 13:43:12 PDT 
Comment on attachment 232679 [details]
Patch

Wait, I am not sure this is a good idea. If the object really is move-only then it seems strange to change it to &&.
Comment 3 Darin Adler 2014-06-17 14:06:53 PDT 
Anders, what do you think of this from a coding style point of view?
Comment 4 Anders Carlsson 2014-06-17 14:24:15 PDT 
(In reply to comment #3)
> Anders, what do you think of this from a coding style point of view?

If it's move only it doesn't matter. I don't think it should be an rvalue reference in that case.
Comment 5 Zan Dobersek 2014-06-18 10:54:46 PDT 
Committed r170106: <http://trac.webkit.org/changeset/170106>
Comment 6 Zan Dobersek 2014-06-18 11:05:14 PDT 
Sorry, I missed the comments before landing.

I'll revert these and other ScriptExecutionContext::Task&& parameters in one go, in a different bug.