Bug 133606 – Structure should initialize its previousID in its constructor

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Currently, the Structure constructor that takes a previous structure will initialize its previousID to point to the previous structure's previousID.  This is incorrect.  However, the caller of the Structure::create() factory method (which instantiated the Structure) will later call setPreviousID() to set the previousID to the correct previous structure.  This makes the code confusing to read and more error prone in that the structure relies on client code to fix its invalid previousID.

This patch fixes this by making the Structure constructor initialize previousID correctly.

[Mark Lam]

Created attachment 232661 [details]
the patch

This patch has passed the jsc tests and the layout tests.

[Build Bot]

Comment on attachment 232661 [details]
the patch

Attachment 232661 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6442432270958592

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html

[Build Bot]

Created attachment 232663 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Mark Lam]

(In reply to comment #2)
> (From update of attachment 232661 [details])
> Attachment 232661 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.appspot.com/results/6442432270958592
> 
> New failing tests:
> media/W3C/video/networkState/networkState_during_loadstart.html

I think this failure is unrelated to this patch.  I've re-run the layout tests without incident.  Will try to trigger the ews one more time to see if this repeats.

[Mark Lam]

Created attachment 232672 [details]
same patch.

Uploading the same identical patch again so that I can try another crack at the EWS bots.

[Mark Hahnenberg]

Comment on attachment 232672 [details]
same patch.

r=me assuming the windows build failure was spurious.

[Mark Lam]

Comment on attachment 232672 [details]
same patch.

Windows build failure is spurious since this patch is identical to the previous, and the previous one built without any issues.  I will land this manually after I svn up.

[Mark Lam]

Thanks for the review.  Landed in r169695: <http://trac.webkit.org/r169695>.