Bug 133591 - advanceByCombiningCharacterSequence() can be simplified
Summary: advanceByCombiningCharacterSequence() can be simplified
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-06 16:57 PDT by Myles C. Maxfield
Modified: 2014-06-25 19:34 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.94 KB, patch)
2014-06-23 20:15 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-06-06 16:57:36 PDT 
It can use U16_NEXT() instead.
Comment 1 Myles C. Maxfield 2014-06-23 20:15:49 PDT 
Created attachment 233673 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2014-06-23 20:19:32 PDT 
<rdar://problem/17430091>
Comment 3 WebKit Commit Bot 2014-06-24 16:32:56 PDT 
Comment on attachment 233673 [details]
Patch

Clearing flags on attachment: 233673

Committed r170402: <http://trac.webkit.org/changeset/170402>
Comment 4 WebKit Commit Bot 2014-06-24 16:32:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2014-06-25 19:34:08 PDT 
Comment on attachment 233673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233673&action=review

> Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:275
> +    if (U16_IS_SURROGATE(baseCharacter))

Technically this is incorrect. Since the argument is a UChar32, it should just be U_IS_SURROGATE. But in practice this will work since U16_IS_SURROGATE just calls U_IS_SURROGATE.