Bug 133583 - Should boost ChildProcesses on iOS
Summary: Should boost ChildProcesses on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-06 14:27 PDT by Gavin Barraclough
Modified: 2014-06-10 09:16 PDT (History)
0 users

See Also:

Attachments
Fix (2.14 KB, patch)
2014-06-06 14:28 PDT, Gavin Barraclough 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2014-06-06 14:27:02 PDT 
.
Comment 1 Gavin Barraclough 2014-06-06 14:28:38 PDT 
Created attachment 232628 [details]
Fix
Comment 2 Gavin Barraclough 2014-06-06 14:28:55 PDT 
rdar 17199785
Comment 3 Anders Carlsson 2014-06-06 14:38:48 PDT 
Comment on attachment 232628 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=232628&action=review

> Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:191
> +#if PLATFORM(IOS)
> +    // On iOS, leak a boost onto all child processes
> +    bool leakBoost = true;
> +#elif ENABLE(NETWORK_PROCESS)
> +    // On Mac, leak a boost onto the NetworkProcess.
> +    bool leakBoost = launchOptions.processType == ProcessLauncher::NetworkProcess;
> +#else
> +    bool leakBoost = false;
> +#endif

Please move this to a separate function, something like

static bool shouldLeakBoost(const LaunchOptions&);
Comment 4 Gavin Barraclough 2014-06-06 14:44:42 PDT 
Transmitting file data ..
Committed revision 169663.
Comment 5 Gavin Barraclough 2014-06-06 14:49:31 PDT 
Transmitting file data ..
Committed revision 169663.
Comment 6 David Kilzer (:ddkilzer) 2014-06-10 09:15:24 PDT 
<rdar://problem/17199785>
Comment 7 David Kilzer (:ddkilzer) 2014-06-10 09:16:25 PDT 
<http://trac.webkit.org/changeset/169663>