WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
133583
Should boost ChildProcesses on iOS
https://bugs.webkit.org/show_bug.cgi?id=133583
Summary
Should boost ChildProcesses on iOS
Gavin Barraclough
Reported
2014-06-06 14:27:02 PDT
.
Attachments
Fix
(2.14 KB, patch)
2014-06-06 14:28 PDT
,
Gavin Barraclough
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gavin Barraclough
Comment 1
2014-06-06 14:28:38 PDT
Created
attachment 232628
[details]
Fix
Gavin Barraclough
Comment 2
2014-06-06 14:28:55 PDT
rdar 17199785
Anders Carlsson
Comment 3
2014-06-06 14:38:48 PDT
Comment on
attachment 232628
[details]
Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=232628&action=review
> Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:191 > +#if PLATFORM(IOS) > + // On iOS, leak a boost onto all child processes > + bool leakBoost = true; > +#elif ENABLE(NETWORK_PROCESS) > + // On Mac, leak a boost onto the NetworkProcess. > + bool leakBoost = launchOptions.processType == ProcessLauncher::NetworkProcess; > +#else > + bool leakBoost = false; > +#endif
Please move this to a separate function, something like static bool shouldLeakBoost(const LaunchOptions&);
Gavin Barraclough
Comment 4
2014-06-06 14:44:42 PDT
Transmitting file data .. Committed revision 169663.
Gavin Barraclough
Comment 5
2014-06-06 14:49:31 PDT
Transmitting file data .. Committed revision 169663.
David Kilzer (:ddkilzer)
Comment 6
2014-06-10 09:15:24 PDT
<
rdar://problem/17199785
>
David Kilzer (:ddkilzer)
Comment 7
2014-06-10 09:16:25 PDT
<
http://trac.webkit.org/changeset/169663
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug