Bug 133526 – REGRESSION (iOS WebKit2): Selection rect disappears on touch up on google result

• Status: CLOSED
• Resolution: WONTFIX
• Component: WebKit2

[Enrica Casucci]

Tap and hold on an address after searching for a place in google.
Lifting the finger makes the  selection disappear.

<rdar://problem/16863448>

[Enrica Casucci]

Created attachment 232503 [details]
Patch

[Benjamin Poulain]

Comment on attachment 232503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232503&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:755
> +- (void)cancelHighlight
> +{
> +    [_highlightLongPressGestureRecognizer cancel];
> +}

You can just expose _cancelLongPressGestureRecognizer. Or if you really need a separate call, use [self _cancelLongPressGestureRecognizer].

[Enrica Casucci]

(In reply to comment #2)
> (From update of attachment 232503 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232503&action=review
> 
> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:755
> > +- (void)cancelHighlight
> > +{
> > +    [_highlightLongPressGestureRecognizer cancel];
> > +}
> 
> You can just expose _cancelLongPressGestureRecognizer. Or if you really need a separate call, use [self _cancelLongPressGestureRecognizer].

I did not see that. I'll use that one directly. No need for this patch then. Thanks!