Bug 133506 – CSS JIT: Clean up StackAllocator

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Yusuke Suzuki]

Cleaning up CSS JIT SatkcAcllocator code.

[Yusuke Suzuki]

Created attachment 232469 [details]
Patch

[Benjamin Poulain]

Comment on attachment 232469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232469&action=review

Looks good to me.

> Source/WebCore/cssjit/StackAllocator.h:85
>          if (registerCount % 2) {
> -            m_assembler.pushToSave(registerIDs[registerCount - 1]);
> -            m_offsetFromTop += stackUnitInBytes;
> -            stackReferences.append(StackReference(m_offsetFromTop));
> +            stackReferences.append(push(registerIDs[registerCount - 1]));

WebKit coding style: the brackets should go away when the block only has one line.

> Source/WebCore/cssjit/StackAllocator.h:90
>          for (auto registerID : registerIDs) {
> -            m_assembler.pushToSave(registerID);
> -            m_offsetFromTop += stackUnitInBytes;
> -            stackReferences.append(StackReference(m_offsetFromTop));
> +            stackReferences.append(push(registerID));
>          }

Ditto.

> Source/WebCore/cssjit/StackAllocator.h:114
>          if (registerCountOdd) {
> -            RELEASE_ASSERT(stackReferences[registerCount - 1] == m_offsetFromTop);
> -            RELEASE_ASSERT(m_offsetFromTop >= stackUnitInBytes);
> -            m_offsetFromTop -= stackUnitInBytes;
> -            m_assembler.popToRestore(registerIDs[registerCount - 1]);
> +            pop(stackReferences[registerCount - 1], registerIDs[registerCount - 1]);
>          }

Ditto.

> Source/WebCore/cssjit/StackAllocator.h:126
>          for (unsigned i = registerCount; i > 0; --i) {
> -            RELEASE_ASSERT(stackReferences[i - 1] == m_offsetFromTop);
> -            RELEASE_ASSERT(m_offsetFromTop >= stackUnitInBytes);
> -            m_offsetFromTop -= stackUnitInBytes;
> -            m_assembler.popToRestore(registerIDs[i - 1]);
> +            pop(stackReferences[i - 1], registerIDs[i - 1]);
>          }

Ditto.

[Yusuke Suzuki]

Created attachment 232551 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 232469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232469&action=review

Thank you for your review.

>> Source/WebCore/cssjit/StackAllocator.h:85
>> +            stackReferences.append(push(registerIDs[registerCount - 1]));
> 
> WebKit coding style: the brackets should go away when the block only has one line.

Oh! I've missed it. Thank you.

[Benjamin Poulain]

Comment on attachment 232551 [details]
Patch

Looks good to me.

[WebKit Commit Bot]

Comment on attachment 232551 [details]
Patch

Clearing flags on attachment: 232551

Committed r169621: <http://trac.webkit.org/changeset/169621>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.