Bug 133503 - Enable WebGL on Windows
Summary: Enable WebGL on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Enhancement
Assignee: Nobody
URL:
Keywords: InRadar
: 30625 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-06-03 23:13 PDT by Alex Christensen
Modified: 2014-06-04 17:15 PDT (History)
12 users (show)

See Also:

Attachments
Patch (54.41 KB, patch)
2014-06-03 23:24 PDT, Alex Christensen 		bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-06-03 23:13:15 PDT 
I got WebGL working on Windows again.  Accelerated compositing still needs fixing for performance gains and antialiasing, but it works without it.
Comment 1 Alex Christensen 2014-06-03 23:24:29 PDT 
Created attachment 232467 [details]
Patch
Comment 2 WebKit Commit Bot 2014-06-03 23:26:59 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Brent Fulgham 2014-06-04 14:48:37 PDT 
Comment on attachment 232467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232467&action=review

I think this looks good. Can you fix the date on the file I reference in these notes? r=me.

> Source/ThirdParty/ANGLE/include/EGL/eglsoftlinking.h:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

Copyright 2014, please!

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:686
> +    if (isAccelerated() && renderBox && renderBox->hasAcceleratedCompositing()) {

Since the default case is for accelerated to be true, should this just be an #if/def?
Comment 4 Alex Christensen 2014-06-04 16:35:03 PDT 
http://trac.webkit.org/changeset/169601
Comment 5 Brent Fulgham 2014-06-04 16:52:06 PDT 
<rdar://problem/8234826>
Comment 6 Alex Christensen 2014-06-04 17:15:22 PDT 
*** Bug 30625 has been marked as a duplicate of this bug. ***