Bug 133502 - Scheme of content utils should be compared in an ASCII case-insensitive manner
Summary: Scheme of content utils should be compared in an ASCII case-insensitive manner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-03 22:18 PDT by Gyuyoung Kim
Modified: 2014-06-06 18:29 PDT (History)
8 users (show)

See Also:


Attachments
WIP (1.63 KB, patch)
2014-06-04 17:51 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (11.52 KB, patch)
2014-06-05 07:23 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (11.51 KB, patch)
2014-06-05 07:25 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (501.42 KB, application/zip)
2014-06-05 08:51 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (601.92 KB, application/zip)
2014-06-05 09:02 PDT, Build Bot
no flags Details
Patch (11.44 KB, patch)
2014-06-05 11:56 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch for landing (11.47 KB, patch)
2014-06-06 17:52 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-06-03 22:18:26 PDT
As mentioned in https://bugs.webkit.org/show_bug.cgi?id=133296#c19, whitelist needs to have case-sensitive.

"A scheme, such as mailto or web+auth. The scheme must be compared in an ASCII case-insensitive manner by user agents for the purposes of comparing with the scheme part of URLs that they consider against the list of registered handlers."
Comment 1 Gyuyoung Kim 2014-06-04 17:51:54 PDT
Created attachment 232514 [details]
WIP
Comment 2 Gyuyoung Kim 2014-06-05 07:23:02 PDT
Created attachment 232545 [details]
Patch
Comment 3 Gyuyoung Kim 2014-06-05 07:25:21 PDT
Created attachment 232546 [details]
Patch
Comment 4 Build Bot 2014-06-05 08:51:24 PDT
Comment on attachment 232546 [details]
Patch

Attachment 232546 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6645613751959552

New failing tests:
fast/dom/NavigatorContentUtils/unregister-protocol-handler.html
Comment 5 Build Bot 2014-06-05 08:51:30 PDT
Created attachment 232552 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 6 Build Bot 2014-06-05 09:02:37 PDT
Comment on attachment 232546 [details]
Patch

Attachment 232546 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6215440565010432

New failing tests:
fast/dom/NavigatorContentUtils/unregister-protocol-handler.html
Comment 7 Build Bot 2014-06-05 09:02:45 PDT
Created attachment 232554 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 8 Gyuyoung Kim 2014-06-05 11:56:21 PDT
Created attachment 232572 [details]
Patch
Comment 9 Gyuyoung Kim 2014-06-05 20:06:23 PDT
CC'ing Darin
Comment 10 Darin Adler 2014-06-06 09:18:06 PDT
Comment on attachment 232572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232572&action=review

> Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.cpp:101
> +

No need to add this blank line.
Comment 11 Gyuyoung Kim 2014-06-06 17:52:54 PDT
Created attachment 232639 [details]
Patch for landing
Comment 12 WebKit Commit Bot 2014-06-06 18:29:52 PDT
Comment on attachment 232639 [details]
Patch for landing

Clearing flags on attachment: 232639

Committed r169670: <http://trac.webkit.org/changeset/169670>
Comment 13 WebKit Commit Bot 2014-06-06 18:29:59 PDT
All reviewed patches have been landed.  Closing bug.