Bug 133499 - [CSS Shapes] Fix off by one in creating a RasterShape
Summary: [CSS Shapes] Fix off by one in creating a RasterShape
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-03 20:49 PDT by Bem Jones-Bey
Modified: 2014-06-04 21:07 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.36 KB, patch)
2014-06-03 20:57 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2014-06-03 20:49:50 PDT 
Fix off by one in creating a RasterShape
Comment 1 Bem Jones-Bey 2014-06-03 20:54:56 PDT 
Note that crash is not a security issue because it is caught by a release assert in WTF::Vector.
Comment 2 Bem Jones-Bey 2014-06-03 20:57:49 PDT 
Created attachment 232463 [details]
Patch
Comment 3 Darin Adler 2014-06-04 17:16:42 PDT 
Comment on attachment 232463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232463&action=review

> LayoutTests/ChangeLog:9
> +        * fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash-expected.txt: Added.
> +        * fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash.html: Added.

Would be nicer to do some kind of reference test instead, but maybe that's impractical.
Comment 4 WebKit Commit Bot 2014-06-04 17:46:09 PDT 
Comment on attachment 232463 [details]
Patch

Clearing flags on attachment: 232463

Committed r169604: <http://trac.webkit.org/changeset/169604>
Comment 5 WebKit Commit Bot 2014-06-04 17:46:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Bem Jones-Bey 2014-06-04 21:07:46 PDT 
(In reply to comment #3)
> (From update of attachment 232463 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232463&action=review
> 
> > LayoutTests/ChangeLog:9
> > +        * fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash-expected.txt: Added.
> > +        * fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash.html: Added.
> 
> Would be nicer to do some kind of reference test instead, but maybe that's impractical.

Ref tests for image shapes with different combinations of margin, borders, padding and shape margin are forthcoming. I just wanted to get this one fixed ASAP since it's a crasher. Thanks for the review.