Bug 133499 – [CSS Shapes] Fix off by one in creating a RasterShape

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Bem Jones-Bey]

Fix off by one in creating a RasterShape

[Bem Jones-Bey]

Note that crash is not a security issue because it is caught by a release assert in WTF::Vector.

[Bem Jones-Bey]

Created attachment 232463 [details]
Patch

[Darin Adler]

Comment on attachment 232463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232463&action=review

> LayoutTests/ChangeLog:9
> +        * fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash-expected.txt: Added.
> +        * fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash.html: Added.

Would be nicer to do some kind of reference test instead, but maybe that's impractical.

[WebKit Commit Bot]

Comment on attachment 232463 [details]
Patch

Clearing flags on attachment: 232463

Committed r169604: <http://trac.webkit.org/changeset/169604>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Bem Jones-Bey]

(In reply to comment #3)
> (From update of attachment 232463 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232463&action=review
> 
> > LayoutTests/ChangeLog:9
> > +        * fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash-expected.txt: Added.
> > +        * fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash.html: Added.
> 
> Would be nicer to do some kind of reference test instead, but maybe that's impractical.

Ref tests for image shapes with different combinations of margin, borders, padding and shape margin are forthcoming. I just wanted to get this one fixed ASAP since it's a crasher. Thanks for the review.