Bug 133493 – Fix some corner cases of :hover and :active in quirks mode

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

Fix some corner cases of :hover and :active in quirks mode

[Benjamin Poulain]

Created attachment 232450 [details]
Patch

[Build Bot]

Comment on attachment 232450 [details]
Patch

Attachment 232450 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6196910264156160

New failing tests:
media/W3C/video/src/src_reflects_attribute_not_source_elements.html

[Build Bot]

Created attachment 232454 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Andreas Kling]

Comment on attachment 232450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232450&action=review

r=me.

The test failure seems totally unrelated.

> Source/WebCore/ChangeLog:17
> +        This patch moves the detection quirks mode exception code from the code generator to the Fragment generator.

"detection quirks mode exception code" wut

[Yusuke Suzuki]

Comment on attachment 232450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232450&action=review

The patch looks great to me!

> Source/WebCore/cssjit/SelectorCompiler.cpp:536
> +            fragment.onlyMatchesLinksInQuirksMode = false;

Is it unnecessary to check `tagName == anyQname()`?

[Benjamin Poulain]

(In reply to comment #5)
> (From update of attachment 232450 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232450&action=review
> 
> The patch looks great to me!
> 
> > Source/WebCore/cssjit/SelectorCompiler.cpp:536
> > +            fragment.onlyMatchesLinksInQuirksMode = false;
> 
> Is it unnecessary to check `tagName == anyQname()`?

You are right, I'll add this check when landing.

[Benjamin Poulain]

Created attachment 232466 [details]
Patch for landing

[Benjamin Poulain]

Committed r169585: <http://trac.webkit.org/changeset/169585>