RESOLVED FIXED 133491
Subpixel rendering: border-radius painting falls back to rectangle when the snapped rounded rect becomes non-renderable. 
https://bugs.webkit.org/show_bug.cgi?id=133491
Summary Subpixel rendering: border-radius painting falls back to rectangle when the s...
zalan
Reported 2014-06-03 15:01:25 PDT
ssia
Attachments
Test reduction (234 bytes, text/html)
2014-06-03 15:01 PDT, zalan 		no flags
Details
Patch (5.73 KB, patch)
2014-06-03 15:30 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (7.30 KB, patch)
2014-06-05 09:11 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2014-06-03 15:01:51 PDT
Created attachment 232442 [details] Test reduction
zalan
Comment 2 2014-06-03 15:03:10 PDT
<rdar://problem/17078906>
zalan
Comment 3 2014-06-03 15:30:50 PDT
Created attachment 232444 [details] Patch
Simon Fraser (smfr)
Comment 4 2014-06-04 16:04:18 PDT
Comment on attachment 232444 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232444&action=review > Source/WebCore/platform/graphics/RoundedRect.cpp:250 > + adjustedRadii.setTopLeft(LayoutSize(adjustedRadii.topLeft().width() / horizonalRatio, adjustedRadii.topLeft().height() / verticalRatio)); Would be cleaner if we had LayoutSize::scale(x, y) and you scaled by 1/ratio.
zalan
Comment 5 2014-06-05 09:11:51 PDT
Created attachment 232556 [details] Patch
zalan
Comment 6 2014-06-05 09:18:21 PDT
(In reply to comment #4) > (From update of attachment 232444 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232444&action=review > > > Source/WebCore/platform/graphics/RoundedRect.cpp:250 > > + adjustedRadii.setTopLeft(LayoutSize(adjustedRadii.topLeft().width() / horizonalRatio, adjustedRadii.topLeft().height() / verticalRatio)); > > Would be cleaner if we had LayoutSize::scale(x, y) and you scaled by 1/ratio. We do have it! Fixed.
WebKit Commit Bot
Comment 7 2014-06-05 11:19:10 PDT
Comment on attachment 232556 [details] Patch Clearing flags on attachment: 232556 Committed r169620: <http://trac.webkit.org/changeset/169620>
WebKit Commit Bot
Comment 8 2014-06-05 11:19:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.