Bug 133491 - Subpixel rendering: border-radius painting falls back to rectangle when the snapped rounded rect becomes non-renderable.
Summary: Subpixel rendering: border-radius painting falls back to rectangle when the s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2014-06-03 15:01 PDT by zalan
Modified: 2014-06-05 11:19 PDT (History)
2 users (show)

See Also:

Attachments
Test reduction (234 bytes, text/html)
2014-06-03 15:01 PDT, zalan 		no flags Details
Patch (5.73 KB, patch)
2014-06-03 15:30 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.30 KB, patch)
2014-06-05 09:11 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-06-03 15:01:25 PDT 
ssia
Comment 1 zalan 2014-06-03 15:01:51 PDT 
Created attachment 232442 [details]
Test reduction
Comment 2 zalan 2014-06-03 15:03:10 PDT 
<rdar://problem/17078906>
Comment 3 zalan 2014-06-03 15:30:50 PDT 
Created attachment 232444 [details]
Patch
Comment 4 Simon Fraser (smfr) 2014-06-04 16:04:18 PDT 
Comment on attachment 232444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232444&action=review

> Source/WebCore/platform/graphics/RoundedRect.cpp:250
> +        adjustedRadii.setTopLeft(LayoutSize(adjustedRadii.topLeft().width() / horizonalRatio, adjustedRadii.topLeft().height() / verticalRatio));

Would be cleaner if we had LayoutSize::scale(x, y) and you scaled by 1/ratio.
Comment 5 zalan 2014-06-05 09:11:51 PDT 
Created attachment 232556 [details]
Patch
Comment 6 zalan 2014-06-05 09:18:21 PDT 
(In reply to comment #4)
> (From update of attachment 232444 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232444&action=review
> 
> > Source/WebCore/platform/graphics/RoundedRect.cpp:250
> > +        adjustedRadii.setTopLeft(LayoutSize(adjustedRadii.topLeft().width() / horizonalRatio, adjustedRadii.topLeft().height() / verticalRatio));
> 
> Would be cleaner if we had LayoutSize::scale(x, y) and you scaled by 1/ratio.
We do have it! Fixed.
Comment 7 WebKit Commit Bot 2014-06-05 11:19:10 PDT 
Comment on attachment 232556 [details]
Patch

Clearing flags on attachment: 232556

Committed r169620: <http://trac.webkit.org/changeset/169620>
Comment 8 WebKit Commit Bot 2014-06-05 11:19:14 PDT 
All reviewed patches have been landed.  Closing bug.