Bug 133490 - [iOS][WK2] Restore the visual scroll position instead of the dom scroll position when restoring states from the history
Summary: [iOS][WK2] Restore the visual scroll position instead of the dom scroll posit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-03 14:52 PDT by Benjamin Poulain
Modified: 2014-06-04 16:41 PDT (History)
2 users (show)

See Also:


Attachments
Patch (11.37 KB, patch)
2014-06-03 15:00 PDT, Benjamin Poulain
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-06-03 14:52:26 PDT
[iOS][WK2] Restore the visual scroll position instead of the dom scroll position when restoring states from the history
Comment 1 Benjamin Poulain 2014-06-03 15:00:55 PDT
Created attachment 232441 [details]
Patch
Comment 2 Benjamin Poulain 2014-06-03 15:19:05 PDT
<rdar://problem/16877859>
Comment 3 Tim Horton 2014-06-04 15:47:55 PDT
Comment on attachment 232441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232441&action=review

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:156
> +    // FIXME: ideally, we should sync this with the UIProcess. We should not try to change the position if the user is interaction

s/interaction/interacting/
Comment 4 Benjamin Poulain 2014-06-04 16:41:48 PDT
Committed r169603: <http://trac.webkit.org/changeset/169603>