Bug 13349 – svn-create-patch should support -c NNNNN argument to pull a patch from svn

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Tools / Tests

[David Kilzer (:ddkilzer)]

The svn-create-patch script should support a -rMMMMM:NNNNN argument to pull patches from svn with all the benefits of svn-create-patch run on a locally modified working copy (such as binary diffs and svn cp revision hints).

[David Kilzer (:ddkilzer)]

Created attachment 14045 [details]
WIP v1

WIP.  I don't want to lose these changes!  They need some more time to bake, and there are a few edge cases (like added binary files) that need to be addressed.

[David Kilzer (:ddkilzer)]

Note that this fix will also support a simple "-r NNNNN" argument that "knows" you want to generate a diff for revision "NNNNN" and will subtract one from that revision to create a range.  Brilliant!

[David Kilzer (:ddkilzer)]

(In reply to comment #1)
> WIP.  I don't want to lose these changes!  They need some more time to bake,
> and there are a few edge cases (like added binary files) that need to be
> addressed.

I may also move the "isBinary" check from the generateFileList*() subroutines to inside generateDiff() since it will be obvious when a file is a binary file (from the previous diff output), and it will save some time running more svn commands for each file!

[David Kilzer (:ddkilzer)]

Nits on WIP v1 patch:

1. Broke added files in working copy.
2. "-rNNNNN" without a space doesn't work.

[David Kilzer (:ddkilzer)]

*** Bug 15041 has been marked as a duplicate of this bug. ***

[Ahmad Saleem]

GitHub is now defect - SVN is gone.

Do we need this?

[Darin Adler]

I think we don’t and can close this.

[Ahmad Saleem]

Thanks Darin. Marked as 'RESOLVED WONTFIX'.