Bug 13349 - svn-create-patch should support -c NNNNN argument to pull a patch from svn
Summary: svn-create-patch should support -c NNNNN argument to pull a patch from svn
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 523.x (Safari 3)
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 15041 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-04-13 19:46 PDT by David Kilzer (:ddkilzer)
Modified: 2010-06-10 17:22 PDT (History)
1 user (show)

See Also:


Attachments
WIP v1 (12.20 KB, patch)
2007-04-15 16:58 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2007-04-13 19:46:05 PDT
The svn-create-patch script should support a -rMMMMM:NNNNN argument to pull patches from svn with all the benefits of svn-create-patch run on a locally modified working copy (such as binary diffs and svn cp revision hints).
Comment 1 David Kilzer (:ddkilzer) 2007-04-15 16:58:15 PDT
Created attachment 14045 [details]
WIP v1

WIP.  I don't want to lose these changes!  They need some more time to bake, and there are a few edge cases (like added binary files) that need to be addressed.
Comment 2 David Kilzer (:ddkilzer) 2007-04-15 16:59:48 PDT
Note that this fix will also support a simple "-r NNNNN" argument that "knows" you want to generate a diff for revision "NNNNN" and will subtract one from that revision to create a range.  Brilliant!

Comment 3 David Kilzer (:ddkilzer) 2007-04-15 17:09:40 PDT
(In reply to comment #1)
> WIP.  I don't want to lose these changes!  They need some more time to bake,
> and there are a few edge cases (like added binary files) that need to be
> addressed.

I may also move the "isBinary" check from the generateFileList*() subroutines to inside generateDiff() since it will be obvious when a file is a binary file (from the previous diff output), and it will save some time running more svn commands for each file!

Comment 4 David Kilzer (:ddkilzer) 2007-04-19 19:43:20 PDT
Nits on WIP v1 patch:

1. Broke added files in working copy.
2. "-rNNNNN" without a space doesn't work.

Comment 5 David Kilzer (:ddkilzer) 2009-05-24 07:01:35 PDT
*** Bug 15041 has been marked as a duplicate of this bug. ***