Bug 133486 - Add a background color to Speedometer's iframe
Summary: Add a background color to Speedometer's iframe
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-03 11:26 PDT by Timothy Hatcher
Modified: 2017-01-31 00:43 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.25 KB, patch)
2014-06-03 11:27 PDT, Timothy Hatcher
rniwa: review-
rniwa: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-06-03 11:26:00 PDT
The frame flashes to black between tests on a slower network. It looks better with a light gray background.
Comment 1 Timothy Hatcher 2014-06-03 11:27:14 PDT
Created attachment 232434 [details]
Patch
Comment 2 Mark Lam 2014-06-03 12:28:41 PDT
Comment on attachment 232434 [details]
Patch

rs=me
Comment 3 Ryosuke Niwa 2014-06-03 12:45:11 PDT
Comment on attachment 232434 [details]
Patch

We can't do this. Adding z-index would affect the benchmark.
Comment 4 Ryosuke Niwa 2014-06-03 12:47:58 PDT
Also, if we're making change of this sort, we need to bump up the version number.  Adding a background color can significantly affect the painting & compositing performance.