Bug 133480 – Refactor the srcset parser into its own file

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yoav Weiss]

Refactor the srcset parser into its own file

[Yoav Weiss]

Created attachment 232429 [details]
Patch

[Andreas Kling]

Comment on attachment 232429 [details]
Patch

Sure, r=me

[WebKit Commit Bot]

Comment on attachment 232429 [details]
Patch

Rejecting attachment 232429 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 232429 [details]
Patch

Clearing flags on attachment: 232429

Committed r169573: <http://trac.webkit.org/changeset/169573>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 232429 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232429&action=review

> Source/WebCore/html/parser/HTMLSrcsetParser.h:68
> +// Space characters as defined by the HTML specification.
> +bool isHTMLSpace(UChar);
> +bool isHTMLLineBreak(UChar);
> +bool isNotHTMLSpace(UChar);
> +bool isHTMLSpaceButNotLineBreak(UChar character);

Wait, what? We don’t need these functions in two different header files.

[Darin Adler]

Comment on attachment 232429 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232429&action=review

> Source/WebCore/html/parser/HTMLSrcsetParser.h:48
> +    String imageURL(const String& srcAttribute, const String& srcsetAttribute) const

This should take and return StringView.

> Source/WebCore/html/parser/HTMLSrcsetParser.h:68
> +// Space characters as defined by the HTML specification.
> +bool isHTMLSpace(UChar);
> +bool isHTMLLineBreak(UChar);
> +bool isNotHTMLSpace(UChar);
> +bool isHTMLSpaceButNotLineBreak(UChar character);

Wait, what

[Yoav Weiss]

Both comments are resolved in a followup bug: https://bugs.webkit.org/show_bug.cgi?id=133504