Bug 133471 – Prepopulated tiles may never be unparented from TileGrids with aggressive tile retention on

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Tim Horton]

We only unparent tiles that are in the VisibleTileCohort when cleaning up no-longer-visible tiles. If tiles were created via prepopulateRect() and never made it into the VisibleTileCohort, they won't be unparented (and will thus stick around, nonvolatile, forever, until the scale changes or the primary coverage rect moves to intersect them). This is in some cases a huge waste of memory and time.

We can't just immediately unparent all non-primary-coverage layers, because that would defeat prepopulateRect(). We may be able to make use of the cohort age and unparent them on a subsequent revalidateTiles (and schedule a revalidation timer when we prepopulate, etc.).

[Tim Horton]

Created attachment 232419 [details]
patch

[WebKit Commit Bot]

Attachment 232419 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/ca/mac/TileGrid.h:125:  The parameter name "cohortInfo" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 232419 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232419&action=review

> Source/WebCore/platform/graphics/ca/mac/TileController.h:128
> +
> +

Blank lines.

> Source/WebCore/platform/graphics/ca/mac/TileGrid.h:125
> +    double timeUntilCohortExpires(TileCohortInfo cohortInfo); // move onto cohortinfo?

const TileCohortInfo&. Could be static or moved onto TileCohortInfo.

[Tim Horton]

> > Source/WebCore/platform/graphics/ca/mac/TileGrid.h:125
> > +    double timeUntilCohortExpires(TileCohortInfo cohortInfo); // move onto cohortinfo?
> 
> const TileCohortInfo&. Could be static or moved onto TileCohortInfo.

I totally meant to actually do what that comment said, and forgot. Fixed in the patch that landed. Thanks!

http://trac.webkit.org/changeset/169565