Bug 133442 - Make GraphicsContext::drawImage, drawTiledImage and drawImageBuffer take Image& instead of Image*
Summary: Make GraphicsContext::drawImage, drawTiledImage and drawImageBuffer take Imag...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-01 20:27 PDT by zalan
Modified: 2023-12-04 13:33 PST (History)
1 user (show)

See Also:

Attachments
All image buffer are as 'ImageBuffer&' (617.17 KB, image/png)
2023-12-02 10:12 PST, Ahmad Saleem 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-06-01 20:27:41 PDT 
void drawImage(Image*, ColorSpace, const FloatPoint& destination, const ImagePaintingContext& = ImagePaintingContext());
void drawImage(Image*, ColorSpace, const FloatRect& destination, const ImagePaintingContext& = ImagePaintingContext());
void drawImage(Image*, ColorSpace, const FloatRect& destination, const FloatRect& source, const ImagePaintingContext& = ImagePaintingContext());

void drawTiledImage(Image*, ColorSpace, const FloatRect& destination, const FloatPoint& source, const FloatSize& tileSize, const ImagePaintingContext& = ImagePaintingContext());
void drawTiledImage(Image*, ColorSpace, const FloatRect& destination, const FloatRect& source, const FloatSize& tileScaleFactor, Image::TileRule, Image::TileRule, const ImagePaintingContext& = ImagePaintingContext());

void drawImageBuffer(ImageBuffer*, ColorSpace, const FloatPoint& destination, const ImagePaintingContext& = ImagePaintingContext());
void drawImageBuffer(ImageBuffer*, ColorSpace, const FloatRect& destination, const ImagePaintingContext& = ImagePaintingContext());
void drawImageBuffer(ImageBuffer*, ColorSpace, const FloatRect& destination, const FloatRect& source, const ImagePaintingContext& = ImagePaintingContext());
Comment 1 Ahmad Saleem 2023-12-02 10:12:41 PST 
Created attachment 468839 [details]
All image buffer are as 'ImageBuffer&'

@Alan - from quick search on 'searchfox.org' with following keyword as shown in the picture. All of them are 'ImageBuffer&' instead of 'ImageBuffer*'. Do we need this anymore?
Comment 2 zalan 2023-12-04 13:33:48 PST 
probably not, thanks for looking into this.