Bug 133430 - Web Replay: don't encode/decode primitive types that lack explicit sizes
Summary: Web Replay: don't encode/decode primitive types that lack explicit sizes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brian Burg
URL:
Keywords:
: 133400 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-05-31 21:53 PDT by Brian Burg
Modified: 2014-07-24 15:11 PDT (History)
7 users (show)

See Also:

Attachments
patch (12.18 KB, patch)
2014-06-07 21:15 PDT, Brian Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-05-31 21:53:19 PDT 
We currently serialize unsigned int and int fields for some C++ types and replay inputs. To reduce ambiguity as to what is being serialized, we should instead cast any such type to [u]int{32,64}_t and remove the specializations for unsigned int and int.
Comment 1 Csaba Osztrogonác 2014-06-04 03:00:19 PDT 
*** Bug 133400 has been marked as a duplicate of this bug. ***
Comment 2 Brian Burg 2014-06-07 21:15:03 PDT 
Created attachment 232675 [details]
patch
Comment 3 Csaba Osztrogonác 2014-07-24 02:48:48 PDT 
Anders, Darin, could you review this old patch, please?
It is still needed to fix the web replay build on Linux.
Comment 4 WebKit Commit Bot 2014-07-24 15:11:36 PDT 
Comment on attachment 232675 [details]
patch

Clearing flags on attachment: 232675

Committed r171528: <http://trac.webkit.org/changeset/171528>
Comment 5 WebKit Commit Bot 2014-07-24 15:11:41 PDT 
All reviewed patches have been landed.  Closing bug.