Bug 133423 – Change DeferrableOneShotTimer to use std::function instead of being a class template

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Change DeferrableOneShotTimer to use std::function instead of being a class template

[Anders Carlsson]

Created attachment 232318 [details]
Patch

[WebKit Commit Bot]

Attachment 232318 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/Timer.h:158:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/Timer.h:198:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Created attachment 232319 [details]
Patch

[WebKit Commit Bot]

Attachment 232319 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/Timer.h:158:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/Timer.h:198:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 232319 [details]
Patch

WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp: In member function 'void WebKit::NetworkProcess::platformSetCacheModel(WebKit::CacheModel)':
WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:119:72: error: invalid initialization of reference of type 'std::chrono::seconds& {aka std::chrono::duration<long int>&}' from expression of type 'double'

[Anders Carlsson]

Created attachment 232357 [details]
Patch

[WebKit Commit Bot]

Attachment 232357 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/Timer.h:158:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/Timer.h:198:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Created attachment 232358 [details]
Patch

[WebKit Commit Bot]

Attachment 232358 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/Timer.h:158:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/Timer.h:198:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Csaba Osztrogonác]

Comment on attachment 232358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232358&action=review

> Source/WebKit2/Shared/CacheModel.h:40
> -    unsigned& cacheTotalCapacity, unsigned& cacheMinDeadCapacity, unsigned& cacheMaxDeadCapacity, double& deadDecodedDataDeletionInterval,
> +    unsigned& cacheTotalCapacity, unsigned& cacheMinDeadCapacity, unsigned& cacheMaxDeadCapacity, std::chrono::seconds& deadDecodedDataDeletionInterval,

Please include <chrono> in this header not to break the EFL build.

build log from EFL EWS:

In file included from /mnt/eflews/git/webkit/Source/WebKit2/UIProcess/API/C/WKAPICast.h:30:0,
                 from /mnt/eflews/git/webkit/WebKitBuild/Release/DerivedSources/WebKit2/include/WebKit/WKAPICast.h:1,
                 from /mnt/eflews/git/webkit/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:26:
/mnt/eflews/git/webkit/Source/WebKit2/Shared/CacheModel.h:40:104: error: 'std::chrono' has not been declared
     unsigned& cacheTotalCapacity, unsigned& cacheMinDeadCapacity, unsigned& cacheMaxDeadCapacity, std::chrono::seconds& deadDecodedDataDeletionInterval,
                                                                                                        ^
/mnt/eflews/git/webkit/Source/WebKit2/Shared/CacheModel.h:40:119: error: expected ',' or '...' before '&' token
     unsigned& cacheTotalCapacity, unsigned& cacheMinDeadCapacity, unsigned& cacheMaxDeadCapacity, std::chrono::seconds& deadDecodedDataDeletionInterval,

[Anders Carlsson]

Created attachment 232381 [details]
Patch

[WebKit Commit Bot]

Attachment 232381 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/Timer.h:158:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/Timer.h:198:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Committed r169550: <http://trac.webkit.org/changeset/169550>