Bug 133423 - Change DeferrableOneShotTimer to use std::function instead of being a class template
Summary: Change DeferrableOneShotTimer to use std::function instead of being a class t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-31 11:46 PDT by Anders Carlsson
Modified: 2014-06-02 16:45 PDT (History)
11 users (show)

See Also:

Attachments
Patch (23.16 KB, patch)
2014-05-31 11:50 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (25.74 KB, patch)
2014-05-31 12:18 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (26.48 KB, patch)
2014-06-01 15:34 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (26.53 KB, patch)
2014-06-01 15:40 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (26.51 KB, patch)
2014-06-02 09:04 PDT, Anders Carlsson 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-05-31 11:46:38 PDT 
Change DeferrableOneShotTimer to use std::function instead of being a class template
Comment 1 Anders Carlsson 2014-05-31 11:50:17 PDT 
Created attachment 232318 [details]
Patch
Comment 2 WebKit Commit Bot 2014-05-31 11:51:31 PDT 
Attachment 232318 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/Timer.h:158:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/Timer.h:198:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2014-05-31 12:18:33 PDT 
Created attachment 232319 [details]
Patch
Comment 4 WebKit Commit Bot 2014-05-31 12:20:28 PDT 
Attachment 232319 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/Timer.h:158:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/Timer.h:198:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Darin Adler 2014-05-31 14:56:19 PDT 
Comment on attachment 232319 [details]
Patch

WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp: In member function 'void WebKit::NetworkProcess::platformSetCacheModel(WebKit::CacheModel)':
WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:119:72: error: invalid initialization of reference of type 'std::chrono::seconds& {aka std::chrono::duration<long int>&}' from expression of type 'double'
Comment 6 Anders Carlsson 2014-06-01 15:34:49 PDT 
Created attachment 232357 [details]
Patch
Comment 7 WebKit Commit Bot 2014-06-01 15:36:37 PDT 
Attachment 232357 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/Timer.h:158:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/Timer.h:198:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Anders Carlsson 2014-06-01 15:40:02 PDT 
Created attachment 232358 [details]
Patch
Comment 9 WebKit Commit Bot 2014-06-01 15:41:19 PDT 
Attachment 232358 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/Timer.h:158:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/Timer.h:198:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Csaba Osztrogonác 2014-06-02 06:31:51 PDT 
Comment on attachment 232358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232358&action=review

> Source/WebKit2/Shared/CacheModel.h:40
> -    unsigned& cacheTotalCapacity, unsigned& cacheMinDeadCapacity, unsigned& cacheMaxDeadCapacity, double& deadDecodedDataDeletionInterval,
> +    unsigned& cacheTotalCapacity, unsigned& cacheMinDeadCapacity, unsigned& cacheMaxDeadCapacity, std::chrono::seconds& deadDecodedDataDeletionInterval,

Please include <chrono> in this header not to break the EFL build.

build log from EFL EWS:

In file included from /mnt/eflews/git/webkit/Source/WebKit2/UIProcess/API/C/WKAPICast.h:30:0,
                 from /mnt/eflews/git/webkit/WebKitBuild/Release/DerivedSources/WebKit2/include/WebKit/WKAPICast.h:1,
                 from /mnt/eflews/git/webkit/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:26:
/mnt/eflews/git/webkit/Source/WebKit2/Shared/CacheModel.h:40:104: error: 'std::chrono' has not been declared
     unsigned& cacheTotalCapacity, unsigned& cacheMinDeadCapacity, unsigned& cacheMaxDeadCapacity, std::chrono::seconds& deadDecodedDataDeletionInterval,
                                                                                                        ^
/mnt/eflews/git/webkit/Source/WebKit2/Shared/CacheModel.h:40:119: error: expected ',' or '...' before '&' token
     unsigned& cacheTotalCapacity, unsigned& cacheMinDeadCapacity, unsigned& cacheMaxDeadCapacity, std::chrono::seconds& deadDecodedDataDeletionInterval,
Comment 11 Anders Carlsson 2014-06-02 09:04:27 PDT 
Created attachment 232381 [details]
Patch
Comment 12 WebKit Commit Bot 2014-06-02 09:06:37 PDT 
Attachment 232381 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/Timer.h:158:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/Timer.h:198:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 Anders Carlsson 2014-06-02 16:45:15 PDT 
Committed r169550: <http://trac.webkit.org/changeset/169550>