Bug 133420 – `currentColor` computes to the same colour on all elements, even if 'color' is inherited differently

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chauncey McAskill]

I've linked the test case on JSFiddle in the URL field above. The following URL is a StackOverflow thread explaining the situation in detail :

http://stackoverflow.com/questions/23936150/issues-with-css-currentcolor-keyword-in-ios-and-safari

Essentially under Safari 6 and up (Safari 5, is unaffected), the `currentColor` CSS keyword computes to the same colour (the first colour it initially computes) on all subsequent elements and pseudo-elements. Notably on border and background colour properties.

The keyword will sometimes compute to the proper colours depending on browser re-paints, can't quite reproduce.

This issue is related to :
- https://bugs.webkit.org/show_bug.cgi?id=80454
- https://bugs.webkit.org/show_bug.cgi?id=117776
- https://bugs.webkit.org/show_bug.cgi?id=95083

[Benjamin Poulain]

Created attachment 249678 [details]
Patch

[Darin Adler]

Comment on attachment 249678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249678&action=review

> Source/WebCore/css/StyleResolver.cpp:264
> +            const StyleProperties::PropertyReference current = properties.propertyAt(i);

I suggest auto here. Also, the const doesn’t add anything.

> Source/WebCore/css/StyleResolver.cpp:1718
> +    for (const auto& matchedProperties : matchResult.matchedProperties()) {

I don’t think you needed to add this const here. I believe would be const automatically.

[Benjamin Poulain]

Committed r182130: <http://trac.webkit.org/changeset/182130>