Bug 133413 - REGRESSION (WebKit2): space space to insert period doesn't work in web forms
Summary: REGRESSION (WebKit2): space space to insert period doesn't work in web forms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-30 16:08 PDT by Enrica Casucci
Modified: 2014-06-02 13:43 PDT (History)
0 users

See Also:

Attachments
Patch (23.61 KB, patch)
2014-05-30 16:23 PDT, Enrica Casucci 		no flags Details | Formatted Diff | Diff
Patch that fixes EWS (23.55 KB, patch)
2014-05-30 16:39 PDT, Enrica Casucci 		benjamin: review+
benjamin: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2014-05-30 16:08:02 PDT 
Any input field in Safari shows the problem, using the on-screen keyboard.

<rdar://problem/16948333>
Comment 1 Enrica Casucci 2014-05-30 16:23:51 PDT 
Created attachment 232308 [details]
Patch
Comment 2 Enrica Casucci 2014-05-30 16:36:45 PDT 
I've fixed the EWS failures.
Comment 3 Enrica Casucci 2014-05-30 16:39:08 PDT 
Created attachment 232310 [details]
Patch that fixes EWS
Comment 4 Benjamin Poulain 2014-05-30 16:45:28 PDT 
Comment on attachment 232310 [details]
Patch that fixes EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=232310&action=review

> Source/WebCore/editing/VisibleUnits.cpp:1819
> +// The elements in the returned vector are:
> +// 0 - the character after the given position (if it exists)
> +// 1 - the character before the given position (if it exists)
> +// 2 - the character before the position prior to the given position (if it exists).

Let's make the return value a struct. That way you can name all the values, which is gonna be easier to understand at the call sites.
Comment 5 Enrica Casucci 2014-05-30 17:13:48 PDT 
Landed the change that addresses Ben's comments.
Committed revision 169500.
Comment 6 Darin Adler 2014-05-30 18:05:54 PDT 
Comment on attachment 232310 [details]
Patch that fixes EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=232310&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2488
> +    const UChar noBreakSpace = 0x00A0;

CharacterNames.h already has this constant. Can’t we include that instead of adding a new declaration?
Comment 7 Enrica Casucci 2014-06-02 13:43:50 PDT 
Removed unwanted changes.
Committed revision 169543