Bug 133413 – REGRESSION (WebKit2): space space to insert period doesn't work in web forms

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Enrica Casucci]

Any input field in Safari shows the problem, using the on-screen keyboard.

<rdar://problem/16948333>

[Enrica Casucci]

Created attachment 232308 [details]
Patch

[Enrica Casucci]

I've fixed the EWS failures.

[Enrica Casucci]

Created attachment 232310 [details]
Patch that fixes EWS

[Benjamin Poulain]

Comment on attachment 232310 [details]
Patch that fixes EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=232310&action=review

> Source/WebCore/editing/VisibleUnits.cpp:1819
> +// The elements in the returned vector are:
> +// 0 - the character after the given position (if it exists)
> +// 1 - the character before the given position (if it exists)
> +// 2 - the character before the position prior to the given position (if it exists).

Let's make the return value a struct. That way you can name all the values, which is gonna be easier to understand at the call sites.

[Enrica Casucci]

Landed the change that addresses Ben's comments.
Committed revision 169500.

[Darin Adler]

Comment on attachment 232310 [details]
Patch that fixes EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=232310&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2488
> +    const UChar noBreakSpace = 0x00A0;

CharacterNames.h already has this constant. Can’t we include that instead of adding a new declaration?

[Enrica Casucci]

Removed unwanted changes.
Committed revision 169543