Bug 133393 - -[WKProcessPoolConfiguration setCachePartitionedURLSchemes:] should do a deep copy
Summary: -[WKProcessPoolConfiguration setCachePartitionedURLSchemes:] should do a deep...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-29 16:58 PDT by Anders Carlsson
Modified: 2014-05-29 17:10 PDT (History)
0 users

See Also:

Attachments
Patch (1.58 KB, patch)
2014-05-29 16:58 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-05-29 16:58:32 PDT 
-[WKProcessPoolConfiguration setCachePartitionedURLSchemes:] should do a deep copy
Comment 1 Anders Carlsson 2014-05-29 16:58:42 PDT 
Created attachment 232271 [details]
Patch
Comment 2 mitz 2014-05-29 17:03:21 PDT 
Comment on attachment 232271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232271&action=review

> Source/WebKit2/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:-55
> -    _cachePartitionedURLSchemes = adoptNS([cachePartitionedURLSchemes copy]);

Just use -[NSArray initWithArray:copyItems:].
Comment 3 mitz 2014-05-29 17:06:56 PDT 
Comment on attachment 232271 [details]
Patch

r=me if you address the comment
Comment 4 Anders Carlsson 2014-05-29 17:10:10 PDT 
Committed r169477: <http://trac.webkit.org/changeset/169477>