Bug 133388 - Fix iOS depth buffer clearing issue.
: Fix iOS depth buffer clearing issue.
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebGL
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-29 14:24 PDT by Alex Christensen
Modified: 2014-05-29 15:10 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.98 KB, patch)
2014-05-29 14:27 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-05-29 14:24:43 PDT
On iOS, the depth buffer is not being cleared correctly in WebGLRenderingContext::clearIfComposited because it is always returning after the check for !m_context->layerComposited().  This moves where the layer is being marked as composited from the mac-specific GraphicsContext3D::prepareTexture to the mac and iOS specific display function, which calls drawInCGLContext through its [super display] call.
Comment 1 Alex Christensen 2014-05-29 14:27:24 PDT
Created attachment 232263 [details]
Patch
Comment 2 WebKit Commit Bot 2014-05-29 15:10:48 PDT
Comment on attachment 232263 [details]
Patch

Clearing flags on attachment: 232263

Committed r169467: <http://trac.webkit.org/changeset/169467>
Comment 3 WebKit Commit Bot 2014-05-29 15:10:53 PDT
All reviewed patches have been landed.  Closing bug.